Issue 324983006: Drop support for reading PrefixSet v1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 324983006: Drop support for reading PrefixSet v1. (Closed)

Created:
6 years, 6 months ago by Scott Hess - ex-Googler

Modified:
6 years, 6 months ago

Reviewers:
mattm

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Drop support for reading PrefixSet v1. r253924 "Convert safe-browsing SBPrefix from int32 to uint32." added support for reading the v1 file and re-sorting. Remove that support and let the files just be dropped on read, since few users are hitting the code. BUG=346405 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276312

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -36 lines)			Patch
	M	chrome/browser/safe_browsing/prefix_set.cc	View		3 chunks	+5 lines, -15 lines	0 comments	Download
	M	chrome/browser/safe_browsing/prefix_set_unittest.cc	View		2 chunks	+5 lines, -21 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

Apropos nothing. Just saw an idle branch which could be pruned.

6 years, 6 months ago (2014-06-10 21:55:35 UTC) #1

Scott Hess - ex-Googler

The CQ bit was checked by shess@chromium.org

6 years, 6 months ago (2014-06-11 05:10:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/324983006/1

6 years, 6 months ago (2014-06-11 05:13:39 UTC) #4

Message was sent while issue was closed.

Change committed as 276312

Expand Messages | Collapse Messages