Drop support for reading PrefixSet v1.

chrome/browser/safe_browsing/prefix_set_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/prefix_set.h"
 
 #include <algorithm>
 #include <iterator>
 
 #include "base/file_util.h"
@@ skipping 611 matching lines @@
   EXPECT_FALSE(prefix_set->Exists(kHash6));
 
   EXPECT_TRUE(prefix_set->PrefixExists(kHash1.prefix));
   EXPECT_TRUE(prefix_set->PrefixExists(kHash2.prefix));
   EXPECT_FALSE(prefix_set->PrefixExists(kHash3.prefix));
   EXPECT_FALSE(prefix_set->PrefixExists(kHash4.prefix));
   EXPECT_FALSE(prefix_set->PrefixExists(kHash5.prefix));
   EXPECT_FALSE(prefix_set->PrefixExists(kHash6.prefix));
 }
 
-// Test that a version 1 file is re-ordered correctly on read.
-TEST_F(PrefixSetTest, ReadWriteSigned) {
+// Test that a version 1 file is discarded on read.
+TEST_F(PrefixSetTest, ReadSigned) {
   base::FilePath filename;
   ASSERT_TRUE(GetPrefixSetFile(&filename));
 
   // Open the file for rewrite.
   base::ScopedFILE file(base::OpenFile(filename, "r+b"));
 
   // Leave existing magic.
   ASSERT_NE(-1, fseek(file.get(), sizeof(uint32), SEEK_SET));
 
   // Version 1.
@@ skipping 19 matching lines @@
   ASSERT_EQ(sizeof(delta), fwrite(&delta, 1, sizeof(delta), file.get()));
   ASSERT_EQ(sizeof(delta), fwrite(&delta, 1, sizeof(delta), file.get()));
 
   // Leave space for the digest at the end, and regenerate it.
   base::MD5Digest dummy = { { 0 } };
   ASSERT_EQ(sizeof(dummy), fwrite(&dummy, 1, sizeof(dummy), file.get()));
   ASSERT_TRUE(base::TruncateFile(file.get()));
   CleanChecksum(file.get());
   file.reset();  // Flush updates.
 
-  scoped_ptr<PrefixSet> prefix_set = PrefixSet::LoadFile(filename);
-  ASSERT_TRUE(prefix_set.get());
-
-  // |PrefixExists()| uses |std::upper_bound()| to find a starting point, which
-  // assumes |index_| is sorted.  Depending on how |upper_bound()| is
-  // implemented, if the actual list is sorted by |int32|, then one of these
-  // test pairs should fail.
-  EXPECT_TRUE(prefix_set->PrefixExists(1000u));
-  EXPECT_TRUE(prefix_set->PrefixExists(1023u));
-  EXPECT_TRUE(prefix_set->PrefixExists(static_cast<uint32>(-1000)));
-  EXPECT_TRUE(prefix_set->PrefixExists(static_cast<uint32>(-1000 + 23)));
-
-  std::vector<SBPrefix> prefixes_copy;
-  prefix_set->GetPrefixes(&prefixes_copy);
-  EXPECT_EQ(prefixes_copy.size(), 4u);
-  EXPECT_EQ(prefixes_copy[0], 1000u);
-  EXPECT_EQ(prefixes_copy[1], 1023u);
-  EXPECT_EQ(prefixes_copy[2], static_cast<uint32>(-1000));
-  EXPECT_EQ(prefixes_copy[3], static_cast<uint32>(-1000 + 23));
+  scoped_ptr<safe_browsing::PrefixSet>
+      prefix_set(safe_browsing::PrefixSet::LoadFile(filename));
+  ASSERT_FALSE(prefix_set.get());
 }
 
 // Test that a golden v2 file can be read by the current code.  All platforms
 // generating v2 files are little-endian, so there is no point to testing this
 // transition if/when a big-endian port is added.
 #if defined(ARCH_CPU_LITTLE_ENDIAN)
 TEST_F(PrefixSetTest, Version2) {
   std::vector<SBPrefix> ref_prefixes;
   ASSERT_TRUE(ReadReferencePrefixes(&ref_prefixes));
 
@@ skipping 31 matching lines @@
   const SBFullHash kHash2 = SBFullHashForString("www.evil.com/phishing.html");
 
   EXPECT_TRUE(prefix_set->Exists(kHash1));
   EXPECT_TRUE(prefix_set->Exists(kHash2));
   EXPECT_FALSE(prefix_set->PrefixExists(kHash1.prefix));
   EXPECT_FALSE(prefix_set->PrefixExists(kHash2.prefix));
 }
 #endif
 
 }  // namespace safe_browsing