Skeleton GCMAppHandler for Push API

chrome/browser/services/gcm/gcm_profile_service.cc

Index: chrome/browser/services/gcm/gcm_profile_service.cc
diff --git a/chrome/browser/services/gcm/gcm_profile_service.cc b/chrome/browser/services/gcm/gcm_profile_service.cc
index d4ab7028ab9c9d37dcb7bd9edae2f13c0fb56062..0c640b5dfbfd808f1cce35ea46761a90052082ab 100644
--- a/chrome/browser/services/gcm/gcm_profile_service.cc
+++ b/chrome/browser/services/gcm/gcm_profile_service.cc
@@ -49,7 +49,6 @@ GCMProfileService::GCMProfileService(Profile* profile)
   DCHECK(!profile->IsOffTheRecord());
 
   driver_.reset(new GCMDriverAndroid);
-}

[fgorski, 2014/06/10 17:09:27]

I think I prefer having 2 distinct method. If you worry about duplication, wrap
the last 4 lines in a method.

I'd rather see a clear picture where methods start and end.

[johnme, 2014/06/10 20:33:48]

Done, in fact I moved this code to PushMessagingServiceImpl::Init to avoid
polluting GCMProfileService.

 #else
 GCMProfileService::GCMProfileService(
     Profile* profile,
@@ -66,9 +65,14 @@ GCMProfileService::GCMProfileService(
           LoginUIServiceFactory::GetForProfile(profile_))),
       profile_->GetPath().Append(chrome::kGCMStoreDirname),
       profile_->GetRequestContext());
-}
 #endif  // defined(OS_ANDROID)
 
+  base::Closure lazy_load_app_handlers = base::Bind(
+      PushMessagingServiceImpl::LazyLoadAppHandlers,
+      push_messaging_service_.GetWeakPtr());
+  driver_.SetLazyLoadAppHandlersClosure(lazy_load_app_handlers);
+}
+
 GCMProfileService::GCMProfileService()
     : profile_(NULL),
       push_messaging_service_(this) {