Skeleton GCMAppHandler for Push API

chrome/browser/services/gcm/gcm_profile_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/services/gcm/gcm_profile_service.h"
 
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
@@ skipping 31 matching lines @@
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
 }
 
 #if defined(OS_ANDROID)
 GCMProfileService::GCMProfileService(Profile* profile)
     : profile_(profile),
       push_messaging_service_(this) {
   DCHECK(!profile->IsOffTheRecord());
 
   driver_.reset(new GCMDriverAndroid);
-}

[fgorski, 2014/06/10 17:09:27]

I think I prefer having 2 distinct method. If you worry about duplication, wrap
the last 4 lines in a method.

I'd rather see a clear picture where methods start and end.

[johnme, 2014/06/10 20:33:48]

Done, in fact I moved this code to PushMessagingServiceImpl::Init to avoid
polluting GCMProfileService.

 #else
 GCMProfileService::GCMProfileService(
     Profile* profile,
     scoped_ptr<GCMClientFactory> gcm_client_factory)
     : profile_(profile),
       push_messaging_service_(this) {
   DCHECK(!profile->IsOffTheRecord());
 
   driver_ = CreateGCMDriverDesktop(
       gcm_client_factory.Pass(),
       scoped_ptr<IdentityProvider>(new ProfileIdentityProvider(
           SigninManagerFactory::GetForProfile(profile_),
           ProfileOAuth2TokenServiceFactory::GetForProfile(profile_),
           LoginUIServiceFactory::GetForProfile(profile_))),
       profile_->GetPath().Append(chrome::kGCMStoreDirname),
       profile_->GetRequestContext());
+#endif  // defined(OS_ANDROID)
+
+  base::Closure lazy_load_app_handlers = base::Bind(
+      PushMessagingServiceImpl::LazyLoadAppHandlers,
+      push_messaging_service_.GetWeakPtr());
+  driver_.SetLazyLoadAppHandlersClosure(lazy_load_app_handlers);
 }
-#endif  // defined(OS_ANDROID)
 
 GCMProfileService::GCMProfileService()
     : profile_(NULL),
       push_messaging_service_(this) {
 }
 
 GCMProfileService::~GCMProfileService() {
 }
 
 void GCMProfileService::AddAppHandler(const std::string& app_id,
@@ skipping 19 matching lines @@
     driver_->Shutdown();
     driver_.reset();
   }
 }
 
 void GCMProfileService::SetDriverForTesting(GCMDriver* driver) {
   driver_.reset(driver);
 }
 
 }  // namespace gcm