Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 324893007: Override the user's language settings during tests

Created:
6 years, 6 months ago by Joey Parrish
Modified:
6 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

Override the user's language settings during tests If a user's language is set to anything other than English, the output of various tools may vary from what is expected and cause tests to fail. This fixes several test failures for non-English users. To reproduce the issue, run: LC_ALL=de_DE.UTF-8 ./gyptest.py -a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/lib/TestGyp.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Joey Parrish
6 years, 6 months ago (2014-06-10 22:23:30 UTC) #1
Mark Mentovai
LGTM
6 years, 6 months ago (2014-06-11 13:33:47 UTC) #2
Mark Mentovai
6 years, 6 months ago (2014-06-11 13:34:36 UTC) #3
Committed GYP r1932.

Powered by Google App Engine
This is Rietveld 408576698