Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 324823002: mojo: handle WM_DELETE_WINDOW in native_viewport_x11 (Closed)

Created:
6 years, 6 months ago by tim (not reviewing)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

mojo: handle WM_DELETE_WINDOW in native_viewport_x11 BUG=none R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/services/native_viewport/native_viewport_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
tim (not reviewing)
I think this on its own is safe, undoing a != flip from https://codereview.chromium.org/293033003. However ...
6 years, 6 months ago (2014-06-09 23:22:16 UTC) #1
tim (not reviewing)
On 2014/06/09 23:22:16, timsteele wrote: > I think this on its own is safe, undoing ...
6 years, 6 months ago (2014-06-11 20:26:38 UTC) #2
darin (slow to review)
LGTM
6 years, 6 months ago (2014-06-11 21:51:11 UTC) #3
tim (not reviewing)
The CQ bit was checked by tim@chromium.org
6 years, 6 months ago (2014-06-11 22:14:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/324823002/1
6 years, 6 months ago (2014-06-11 22:16:23 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:34:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:35:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/21918)
6 years, 6 months ago (2014-06-11 22:35:38 UTC) #8
tim (not reviewing)
6 years, 6 months ago (2014-06-12 18:21:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r276745 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698