Issue 293033003: Hook up platform events in Mojo shell on Linux desktop

Issue 293033003: Hook up platform events in Mojo shell on Linux desktop (Closed)

Created:
6 years, 7 months ago by Aaron Boodman

Modified:
6 years, 7 months ago

Reviewers:
sadrul, Ben Goodger (Google)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tdresser+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Hook up platform events in Mojo shell on Linux desktop. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272360

Patch Set 1 #

Patch Set 2 : Plumb events through to sample app #

Patch Set 3 : turns out windows needs the change too. #

Patch Set 4 : whitespace #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -15 lines)			Patch
M	mojo/service_manager/background_service_loader.h	View		3 chunks	+4 lines, -1 line	0 comments	Download
M	mojo/service_manager/background_service_loader.cc	View		3 chunks	+7 lines, -2 lines	0 comments	Download
M	mojo/services/native_viewport/native_viewport_service.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/services/native_viewport/native_viewport_x11.cc	View	1	5 chunks	+47 lines, -10 lines	0 comments	Download
M	mojo/shell/context.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

I'm waiting to hear from Ben on where this work is done on Windows, to ...

6 years, 7 months ago (2014-05-22 16:33:53 UTC) #1

Aaron Boodman

Nevermind that last comment. Turns out Windows wasn't working either.

6 years, 7 months ago (2014-05-22 17:49:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/293033003/130001

6 years, 7 months ago (2014-05-22 22:38:24 UTC) #7

Message was sent while issue was closed.

Change committed as 272360

Expand Messages | Collapse Messages