Issue 324783002: Mojo: Add a MojoCreateMessagePipeOptions struct parameter to MojoCreateMessagePipe.

Issue 324783002: Mojo: Add a MojoCreateMessagePipeOptions struct parameter to MojoCreateMessagePipe. (Closed)

Created:
6 years, 6 months ago by viettrungluu

Modified:
6 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Add a MojoCreateMessagePipeOptions struct parameter to MojoCreateMessagePipe. I still need to plumb it through to various other languages. (Also, as a drive-by, use SharedBufferDispatcher::kDefaultCreateOptions in a few tests, which I previously missed.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276134

Patch Set 1 #

Patch Set 2 : rebased #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+175 lines, -63 lines)			Patch
M	mojo/android/system/core_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/bindings/js/core.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/embedder/embedder_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	mojo/public/c/system/message_pipe.h	View	3 chunks	+34 lines, -2 lines	0 comments	Download
M	mojo/public/c/system/tests/core_perftest.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	mojo/public/c/system/tests/core_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/c/system/tests/core_unittest_pure_c.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/cpp/system/core.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	mojo/public/platform/native/system_thunks.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/public/platform/native/system_thunks.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	mojo/system/core.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/system/core.cc	View	1 chunk	+12 lines, -3 lines	0 comments	Download
M	mojo/system/core_unittest.cc	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	mojo/system/data_pipe.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	mojo/system/entrypoints.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	mojo/system/message_pipe_dispatcher.h	View	2 chunks	+18 lines, -1 line	0 comments	Download
M	mojo/system/message_pipe_dispatcher.cc	View	4 chunks	+41 lines, -3 lines	0 comments	Download
M	mojo/system/message_pipe_dispatcher_unittest.cc	View	6 chunks	+24 lines, -12 lines	0 comments	Download
M	mojo/system/multiprocess_message_pipe_unittest.cc	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	mojo/system/remote_message_pipe_unittest.cc	View	2 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

(Dependent on https://codereview.chromium.org/320343002/ and https://codereview.chromium.org/320263004/.)

6 years, 6 months ago (2014-06-09 21:41:16 UTC) #1

viettrungluu

6 years, 6 months ago (2014-06-10 20:50:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r276134 (presubmit successful).

Expand Messages | Collapse Messages