mojo/bindings/js/core.cc - Issue 324783002: Mojo: Add a MojoCreateMessagePipeOptions struct parameter to MojoCreateMessagePipe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/bindings/js/core.cc

Issue 324783002: Mojo: Add a MojoCreateMessagePipeOptions struct parameter to MojoCreateMessagePipe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/bindings/js/core.cc

diff --git a/mojo/bindings/js/core.cc b/mojo/bindings/js/core.cc

index 976a5346140c0253e005fc4dc7a4c5e8fcdf190f..0d75ce5a8c633c8da52faa46e19e6eee11cb6607 100644

--- a/mojo/bindings/js/core.cc

+++ b/mojo/bindings/js/core.cc

@@ -46,7 +46,8 @@ MojoResult WaitMany(

gin::Dictionary CreateMessagePipe(const gin::Arguments& args) {

MojoHandle handle0 = MOJO_HANDLE_INVALID;

MojoHandle handle1 = MOJO_HANDLE_INVALID;

- MojoResult result = MojoCreateMessagePipe(&handle0, &handle1);

+ // TODO(vtl): Add support for the options struct.

+ MojoResult result = MojoCreateMessagePipe(NULL, &handle0, &handle1);

CHECK(result == MOJO_RESULT_OK);

gin::Dictionary dictionary = gin::Dictionary::CreateEmpty(args.isolate());

« no previous file with comments | « mojo/android/system/core_impl.cc ('k') | mojo/embedder/embedder_unittest.cc » ('j') | no next file with comments »