Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/message_center/cocoa/tray_view_controller.mm

Issue 324583002: The 1st patch to disambiguate message center notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Justin's comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/chromeos/display/display_preferences_unittest.cc ('K') | « chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc ('k') | ui/message_center/fake_message_center.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/cocoa/tray_view_controller.mm
diff --git a/ui/message_center/cocoa/tray_view_controller.mm b/ui/message_center/cocoa/tray_view_controller.mm
index 674305171de4fc832ebf15b7d5a897739aeebb34..93bac88d8038178b350a286ebc564a1157ba79e6 100644
--- a/ui/message_center/cocoa/tray_view_controller.mm
+++ b/ui/message_center/cocoa/tray_view_controller.mm
@@ -661,7 +661,8 @@ const CGFloat kTrayBottomMargin = 75;
// Fade-out those notifications pending removal.
for (MCNotificationController* notification in notifications_.get()) {
- if (messageCenter_->HasNotification([notification notificationID]))
+ if (messageCenter_->FindVisibleNotificationById(
+ [notification notificationID]))
continue;
[notificationsPendingRemoval_ addObject:notification];
[animationDataArray addObject:@{
« chrome/browser/chromeos/display/display_preferences_unittest.cc ('K') | « chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc ('k') | ui/message_center/fake_message_center.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698