chrome/browser/notifications/message_center_notification_manager.cc - Issue 324583002: The 1st patch to disambiguate message center notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notification_manager.cc

Issue 324583002: The 1st patch to disambiguate message center notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Justin's comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/display/display_preferences_unittest.cc ('K') | « chrome/browser/notifications/extension_welcome_notification_unittest.cc ('k') | chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/message_center_notification_manager.cc

diff --git a/chrome/browser/notifications/message_center_notification_manager.cc b/chrome/browser/notifications/message_center_notification_manager.cc

index aab2b318c6f9b1353d3f0633c04232567f966c62..b032c4eed99564e14156e5f749e25207e00bf081 100644

--- a/chrome/browser/notifications/message_center_notification_manager.cc

+++ b/chrome/browser/notifications/message_center_notification_manager.cc

@@ -138,7 +138,7 @@ bool MessageCenterNotificationManager::Update(const Notification& notification,

// the immediate update allowed in the message center.

std::string old_id =

old_notification->notification().notification_id();

- DCHECK(message_center_->HasNotification(old_id));

+ DCHECK(message_center_->FindVisibleNotificationById(old_id));

// Add/remove notification in the local list but just update the same

// one in MessageCenter.