Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 324503003: Report data reduction proxy related daily content lengths even if zero (Closed)

Created:
6 years, 6 months ago by bolian
Modified:
6 years, 6 months ago
Reviewers:
bengr, Matt Welsh
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reporting data reduction proxy related daily content lengths if even they are zeros. BUG=376486 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275631

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -40 lines) Patch
M components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc View 1 1 chunk +33 lines, -40 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bolian
6 years, 6 months ago (2014-06-06 20:19:45 UTC) #1
bolian
Hi Ben, This CL is ready for review. Thanks!
6 years, 6 months ago (2014-06-06 20:20:15 UTC) #2
Matt Welsh
lgtm
6 years, 6 months ago (2014-06-06 20:23:19 UTC) #3
bengr
lgtm, with nit and change the title to "Report data reduction proxy related daily content ...
6 years, 6 months ago (2014-06-06 20:41:34 UTC) #4
bolian
Title changed. Thanks. https://codereview.chromium.org/324503003/diff/1/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc File components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc (right): https://codereview.chromium.org/324503003/diff/1/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc#newcode151 components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc:151: DCHECK_GE(received_length_via_data_reduction_proxy, 0); On 2014/06/06 20:41:34, bengr1 ...
6 years, 6 months ago (2014-06-06 20:56:18 UTC) #5
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 6 months ago (2014-06-06 20:56:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/324503003/20001
6 years, 6 months ago (2014-06-06 20:58:16 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 04:21:30 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 06:08:03 UTC) #9
Message was sent while issue was closed.
Change committed as 275631

Powered by Google App Engine
This is Rietveld 408576698