Report data reduction proxy related daily content lengths even if zero

components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h"
 
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 94 matching lines @@
         original_length_with_data_reduction_enabled;
   }
   UMA_HISTOGRAM_PERCENTAGE(
       "Net.DailyContentSavingPercent_DataReductionProxyEnabled",
       percent_data_reduction_proxy_enabled);
 
   UMA_HISTOGRAM_PERCENTAGE(
       "Net.DailyContentPercent_DataReductionProxyEnabled",
       (100 * received_length_with_data_reduction_enabled) / received_length);
 
-  if (https_length_with_data_reduction_enabled > 0) {
-    UMA_HISTOGRAM_COUNTS(
-        "Net.DailyContentLength_DataReductionProxyEnabled_Https",
-        https_length_with_data_reduction_enabled >> 10);
-    UMA_HISTOGRAM_PERCENTAGE(
-        "Net.DailyContentPercent_DataReductionProxyEnabled_Https",
-        (100 * https_length_with_data_reduction_enabled) / received_length);
-  }
+  DCHECK_GE(https_length_with_data_reduction_enabled, 0);
+  UMA_HISTOGRAM_COUNTS(
+      "Net.DailyContentLength_DataReductionProxyEnabled_Https",
+      https_length_with_data_reduction_enabled >> 10);
+  UMA_HISTOGRAM_PERCENTAGE(
+      "Net.DailyContentPercent_DataReductionProxyEnabled_Https",
+      (100 * https_length_with_data_reduction_enabled) / received_length);
 
-  if (short_bypass_length_with_data_reduction_enabled > 0) {
-    UMA_HISTOGRAM_COUNTS(
-        "Net.DailyContentLength_DataReductionProxyEnabled_ShortBypass",
-        short_bypass_length_with_data_reduction_enabled >> 10);
-    UMA_HISTOGRAM_PERCENTAGE(
-        "Net.DailyContentPercent_DataReductionProxyEnabled_ShortBypass",
-        ((100 * short_bypass_length_with_data_reduction_enabled) /
-         received_length));
-  }
+  DCHECK_GE(short_bypass_length_with_data_reduction_enabled, 0);
+  UMA_HISTOGRAM_COUNTS(
+      "Net.DailyContentLength_DataReductionProxyEnabled_ShortBypass",
+      short_bypass_length_with_data_reduction_enabled >> 10);
+  UMA_HISTOGRAM_PERCENTAGE(
+      "Net.DailyContentPercent_DataReductionProxyEnabled_ShortBypass",
+      ((100 * short_bypass_length_with_data_reduction_enabled) /
+       received_length));
 
-  if (long_bypass_length_with_data_reduction_enabled > 0) {
-    UMA_HISTOGRAM_COUNTS(
-        "Net.DailyContentLength_DataReductionProxyEnabled_LongBypass",
-        long_bypass_length_with_data_reduction_enabled >> 10);
-    UMA_HISTOGRAM_PERCENTAGE(
-        "Net.DailyContentPercent_DataReductionProxyEnabled_LongBypass",
-        ((100 * long_bypass_length_with_data_reduction_enabled) /
-         received_length));
-  }
+  DCHECK_GE(long_bypass_length_with_data_reduction_enabled, 0);
+  UMA_HISTOGRAM_COUNTS(
+      "Net.DailyContentLength_DataReductionProxyEnabled_LongBypass",
+      long_bypass_length_with_data_reduction_enabled >> 10);
+  UMA_HISTOGRAM_PERCENTAGE(
+      "Net.DailyContentPercent_DataReductionProxyEnabled_LongBypass",
+      ((100 * long_bypass_length_with_data_reduction_enabled) /
+       received_length));
 
-  if (unknown_length_with_data_reduction_enabled > 0) {
-    UMA_HISTOGRAM_COUNTS(
-        "Net.DailyContentLength_DataReductionProxyEnabled_Unknown",
-        unknown_length_with_data_reduction_enabled >> 10);
-    UMA_HISTOGRAM_PERCENTAGE(
-        "Net.DailyContentPercent_DataReductionProxyEnabled_Unknown",
-        ((100 * unknown_length_with_data_reduction_enabled) /
-         received_length));
-  }
+  DCHECK_GE(unknown_length_with_data_reduction_enabled, 0);
+  UMA_HISTOGRAM_COUNTS(
+      "Net.DailyContentLength_DataReductionProxyEnabled_Unknown",
+      unknown_length_with_data_reduction_enabled >> 10);
+  UMA_HISTOGRAM_PERCENTAGE(
+      "Net.DailyContentPercent_DataReductionProxyEnabled_Unknown",
+      ((100 * unknown_length_with_data_reduction_enabled) /
+       received_length));
 
-  if (original_length_via_data_reduction_proxy <= 0 ||
-      received_length_via_data_reduction_proxy <= 0) {
-    return;
-  }
-
+  DCHECK_GE(original_length_via_data_reduction_proxy, 0);
+  DCHECK_GE(received_length_via_data_reduction_proxy, 0);

[bengr, 2014/06/06 20:41:34]

Move this down to just before the UMA that refers to the variable.

[bolian, 2014/06/06 20:56:17]

Done.

   UMA_HISTOGRAM_COUNTS(
       "Net.DailyOriginalContentLength_ViaDataReductionProxy",
       original_length_via_data_reduction_proxy >> 10);
   UMA_HISTOGRAM_COUNTS(
       "Net.DailyContentLength_ViaDataReductionProxy",
       received_length_via_data_reduction_proxy >> 10);
   int percent_via_data_reduction_proxy = 0;
   if (original_length_via_data_reduction_proxy >
       received_length_via_data_reduction_proxy) {
     percent_via_data_reduction_proxy =
@@ skipping 371 matching lines @@
   UpdateContentLengthPrefsForDataReductionProxy(
       received_content_length,
       original_content_length,
       with_data_reduction_proxy_enabled,
       request_type,
       base::Time::Now(),
       prefs);
 }
 
 }  // namespace data_reduction_proxy