Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: tools/telemetry/unittest_data/test_page_set.py

Issue 324503002: Add optional cloud bucket permission property to page and page_set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing review comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/unittest_data/test_page_set.py
diff --git a/tools/telemetry/unittest_data/test_page_set.py b/tools/telemetry/unittest_data/test_page_set.py
index 0dd8a221f5a8ffa99696e2b285adf094fa1c1745..d30d7c8056bdc4a62961871ec8ec446c20b2e797 100644
--- a/tools/telemetry/unittest_data/test_page_set.py
+++ b/tools/telemetry/unittest_data/test_page_set.py
@@ -2,26 +2,27 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-from telemetry.page.page_set import PageSet
-from telemetry.page.page import Page
+from telemetry.page import page_set as page_set_module
+from telemetry.page import page as page_module
tonyg 2014/06/09 22:02:37 I think the style guide frowns on these. If they'r
from unittest_data.pages.external_page import ExternalPage
-class InternalPage(Page):
+class InternalPage(page_module.Page):
def __init__(self, ps):
super(InternalPage, self).__init__('file://bar.html', page_set=ps)
-class TestPageSet(PageSet):
+class TestPageSet(page_set_module.PageSet):
"""A pageset for testing purpose"""
def __init__(self):
super(TestPageSet, self).__init__(
archive_data_file='data/test.json',
credentials_path='data/credential',
- user_agent_type='desktop')
+ user_agent_type='desktop',
+ privacy_bucket=page_set_module.PUBLIC_BUCKET)
#top google property; a google tab is often open
- class Google(Page):
+ class Google(page_module.Page):
def __init__(self, ps):
super(Google, self).__init__('https://www.google.com', page_set=ps)

Powered by Google App Engine
This is Rietveld 408576698