Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: tools/telemetry/unittest_data/test_page_set.py

Issue 324503002: Add optional cloud bucket permission property to page and page_set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing review comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.page.page_set import PageSet 5 from telemetry.page import page_set as page_set_module
6 from telemetry.page.page import Page 6 from telemetry.page import page as page_module
tonyg 2014/06/09 22:02:37 I think the style guide frowns on these. If they'r
7 7
8 from unittest_data.pages.external_page import ExternalPage 8 from unittest_data.pages.external_page import ExternalPage
9 9
10 class InternalPage(Page): 10 class InternalPage(page_module.Page):
11 def __init__(self, ps): 11 def __init__(self, ps):
12 super(InternalPage, self).__init__('file://bar.html', page_set=ps) 12 super(InternalPage, self).__init__('file://bar.html', page_set=ps)
13 13
14 class TestPageSet(PageSet): 14 class TestPageSet(page_set_module.PageSet):
15 """A pageset for testing purpose""" 15 """A pageset for testing purpose"""
16 16
17 def __init__(self): 17 def __init__(self):
18 super(TestPageSet, self).__init__( 18 super(TestPageSet, self).__init__(
19 archive_data_file='data/test.json', 19 archive_data_file='data/test.json',
20 credentials_path='data/credential', 20 credentials_path='data/credential',
21 user_agent_type='desktop') 21 user_agent_type='desktop',
22 privacy_bucket=page_set_module.PUBLIC_BUCKET)
22 23
23 #top google property; a google tab is often open 24 #top google property; a google tab is often open
24 class Google(Page): 25 class Google(page_module.Page):
25 def __init__(self, ps): 26 def __init__(self, ps):
26 super(Google, self).__init__('https://www.google.com', page_set=ps) 27 super(Google, self).__init__('https://www.google.com', page_set=ps)
27 28
28 def RunGetActionRunner(self, action_runner): 29 def RunGetActionRunner(self, action_runner):
29 return action_runner 30 return action_runner
30 31
31 self.AddPage(Google(self)) 32 self.AddPage(Google(self))
32 self.AddPage(InternalPage(self)) 33 self.AddPage(InternalPage(self))
33 self.AddPage(ExternalPage(self)) 34 self.AddPage(ExternalPage(self))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698