Another try at fixing --enable-logging on Windows

base/process/launch_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process/launch.h"
 
 #include <fcntl.h>
 #include <io.h>
 #include <shellapi.h>
 #include <windows.h>
@@ skipping 46 matching lines @@
   // that case, we don't want to open CONOUT$, because its output
   // likely does not go anywhere.
   //
   // We don't use GetStdHandle() to check stdout/stderr here because
   // it can return dangling IDs of handles that were never inherited
   // by this process.  These IDs could have been reused by the time
   // this function is called.  The CRT checks the validity of
   // stdout/stderr on startup (before the handle IDs can be reused).
   // _fileno(stdout) will return -2 (_NO_CONSOLE_FILENO) if stdout was
   // invalid.
-  if (_fileno(stdout) >= 0 || _fileno(stderr) >= 0)
+
+  // TODO(scottmg):
+  // Unfortunately _fileno was broken in VS2012, and is still broken in VS2013.
+  //   https://connect.microsoft.com/VisualStudio/feedback/details/785119/
+  //   http://crbug.com/358267
+  // It never returns -2 as it is documented to do (and per above) when in a
+  // windowed application without a console. As a result, we have to use
+  // GetStdHandle, even though it's not strictly correct. Hopefully this can
+  // be removed after a future revision of the CRT.
+  if ((_fileno(stdout) >= 0 && GetStdHandle(STD_OUTPUT_HANDLE) != NULL) ||
+      (_fileno(stderr) >= 0 && GetStdHandle(STD_ERROR_HANDLE)) != NULL)
     return;
 
   if (!AttachConsole(ATTACH_PARENT_PROCESS)) {
     unsigned int result = GetLastError();
     // Was probably already attached.
     if (result == ERROR_ACCESS_DENIED)
       return;
     // Don't bother creating a new console for each child process if the
     // parent process is invalid (eg: crashed).
     if (result == ERROR_GEN_FAILURE)
@@ skipping 284 matching lines @@
   WaitForSingleObject(proc_info.process_handle(), INFINITE);
 
   return true;
 }
 
 void RaiseProcessToHighPriority() {
   SetPriorityClass(GetCurrentProcess(), HIGH_PRIORITY_CLASS);
 }
 
 }  // namespace base