ash: Improve low-battery notification thresholds.

ash: Improve low-battery notification thresholds.

Use rounded minute and percentage values when determining
when to show low-battery notifications. Also round
minutes-to-empty values shown in notifications.

BUG=chrome-os-partner:23458
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230353

[James Cook, 2013-10-22 00:32:39]

LGTM with optional nit

https://codereview.chromium.org/32443004/diff/1/ash/system/chromeos/power/pow...
File ash/system/chromeos/power/power_status.cc (right):

https://codereview.chromium.org/32443004/diff/1/ash/system/chromeos/power/pow...
ash/system/chromeos/power/power_status.cc:115: const double seconds =
nit: Do you want to comment either here or in the header that the seconds are
rounded and not truncated?

[Daniel Erat, 2013-10-22 03:22:04]

https://codereview.chromium.org/32443004/diff/1/ash/system/chromeos/power/pow...
File ash/system/chromeos/power/power_status.cc (right):

https://codereview.chromium.org/32443004/diff/1/ash/system/chromeos/power/pow...
ash/system/chromeos/power/power_status.cc:115: const double seconds =
On 2013/10/22 00:32:40, James Cook wrote:
> nit: Do you want to comment either here or in the header that the seconds are
> rounded and not truncated?

Sure, updated the comment in the header.

[commit-bot: I haz the power, 2013-10-22 03:23:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/32443004/70001

[commit-bot: I haz the power, 2013-10-22 04:54:52]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-22 16:22:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/32443004/70001

[commit-bot: I haz the power, 2013-10-22 22:58:47]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-10-22 23:08:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/32443004/70001

[commit-bot: I haz the power, 2013-10-23 02:40:04]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Daniel Erat, 2013-10-23 02:48:38]

On 2013/10/23 02:40:04, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build on win7_aura.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.

win7_aura, wtf

[commit-bot: I haz the power, 2013-10-23 02:49:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/32443004/70001

[commit-bot: I haz the power, 2013-10-23 06:39:16]

Change committed as 230353