ash/system/chromeos/power/power_status.cc - Issue 32443004: ash: Improve low-battery notification thresholds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/chromeos/power/power_status.cc

Issue 32443004: ash: Improve low-battery notification thresholds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: apply review feedback: update comment Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/system/chromeos/power/power_status.cc

diff --git a/ash/system/chromeos/power/power_status.cc b/ash/system/chromeos/power/power_status.cc

index 0283a0c3fece1e9faca6ad44302b86019b1ba79f..6b05401891118bd8cf960948af14c78a5d5d37fc 100644

--- a/ash/system/chromeos/power/power_status.cc

+++ b/ash/system/chromeos/power/power_status.cc

@@ -112,7 +112,9 @@ void PowerStatus::SplitTimeIntoHoursAndMinutes(const base::TimeDelta& time,

DCHECK(hours);

DCHECK(minutes);

*hours = time.InHours();

- *minutes = (time - base::TimeDelta::FromHours(*hours)).InMinutes();

+ const double seconds =

+ (time - base::TimeDelta::FromHours(*hours)).InSecondsF();

+ *minutes = static_cast<int>(seconds / 60.0 + 0.5);

}

void PowerStatus::AddObserver(Observer* observer) {