Extension Toolbar redesign, part 1 (overflow)

extensions/common/feature_switch.cc

Index: extensions/common/feature_switch.cc
diff --git a/extensions/common/feature_switch.cc b/extensions/common/feature_switch.cc
index 121dceb25ce89b7efb04f8e5cdde4e4dd52a1ada..8f82ac12b93aa72d55cbfb50e79e8c0cfe5182d5 100644
--- a/extensions/common/feature_switch.cc
+++ b/extensions/common/feature_switch.cc
@@ -40,6 +40,9 @@ class CommonSwitches {
         error_console(
             switches::kErrorConsole,
             FeatureSwitch::DEFAULT_DISABLED),
+        extension_action_redesign(
+            switches::kExtensionActionRedesign,

[Devlin, 2014/06/23 17:55:29]

nit: Can we have the order in the .h, the static class, and the definition below
all be similar?

[Finnur, 2014/06/25 16:18:11]

Sure. My initial plan was to reorder this list to be alphabetical (and that was
even part of the initial CL), but when I got merge conflicts I decided it would
be better done as a follow-up. I did make the order of this consistent, though.

+            FeatureSwitch::DEFAULT_ENABLED),

[Devlin, 2014/06/23 17:55:29]

This is scary.  Should this really be enabled by default?

[Finnur, 2014/06/25 16:18:11]

Gaaaa! No. Good catch.

On 2014/06/23 17:55:29, Devlin wrote:

         enable_override_bookmarks_ui(
             switches::kEnableOverrideBookmarksUI,
             FeatureSwitch::DEFAULT_DISABLED),
@@ -58,6 +61,7 @@ class CommonSwitches {
   FeatureSwitch prompt_for_external_extensions;
 
   FeatureSwitch error_console;
+  FeatureSwitch extension_action_redesign;
   FeatureSwitch enable_override_bookmarks_ui;
   FeatureSwitch scripts_require_action;
 };
@@ -85,7 +89,9 @@ FeatureSwitch* FeatureSwitch::error_console() {
 FeatureSwitch* FeatureSwitch::enable_override_bookmarks_ui() {
   return &g_common_switches.Get().enable_override_bookmarks_ui;
 }
-
+FeatureSwitch* FeatureSwitch::extension_action_redesign() {
+  return &g_common_switches.Get().extension_action_redesign;
+}
 FeatureSwitch* FeatureSwitch::scripts_require_action() {
   return &g_common_switches.Get().scripts_require_action;
 }