Extension Toolbar redesign, part 1 (overflow)

extensions/common/feature_switch.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/feature_switch.h"
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string_util.h"
@@ skipping 22 matching lines @@
         prompt_for_external_extensions(
             NULL,
 #if defined(OS_WIN)
             FeatureSwitch::DEFAULT_ENABLED),
 #else
             FeatureSwitch::DEFAULT_DISABLED),
 #endif
         error_console(
             switches::kErrorConsole,
             FeatureSwitch::DEFAULT_DISABLED),
+        extension_action_redesign(
+            switches::kExtensionActionRedesign,

[Devlin, 2014/06/23 17:55:29]

nit: Can we have the order in the .h, the static class, and the definition below
all be similar?

[Finnur, 2014/06/25 16:18:11]

Sure. My initial plan was to reorder this list to be alphabetical (and that was
even part of the initial CL), but when I got merge conflicts I decided it would
be better done as a follow-up. I did make the order of this consistent, though.

+            FeatureSwitch::DEFAULT_ENABLED),

[Devlin, 2014/06/23 17:55:29]

This is scary.  Should this really be enabled by default?

[Finnur, 2014/06/25 16:18:11]

Gaaaa! No. Good catch.

On 2014/06/23 17:55:29, Devlin wrote:

         enable_override_bookmarks_ui(
             switches::kEnableOverrideBookmarksUI,
             FeatureSwitch::DEFAULT_DISABLED),
         scripts_require_action(switches::kScriptsRequireAction,
                                FeatureSwitch::DEFAULT_DISABLED) {}
 
   // Enables extensions to be easily installed from sites other than the web
   // store.
   FeatureSwitch easy_off_store_install;
 
   FeatureSwitch force_dev_mode_highlighting;
   FeatureSwitch global_commands;
 
   // Should we prompt the user before allowing external extensions to install?
   // Default is yes.
   FeatureSwitch prompt_for_external_extensions;
 
   FeatureSwitch error_console;
+  FeatureSwitch extension_action_redesign;
   FeatureSwitch enable_override_bookmarks_ui;
   FeatureSwitch scripts_require_action;
 };
 
 base::LazyInstance<CommonSwitches> g_common_switches =
     LAZY_INSTANCE_INITIALIZER;
 
 }  // namespace
 
 FeatureSwitch* FeatureSwitch::force_dev_mode_highlighting() {
   return &g_common_switches.Get().force_dev_mode_highlighting;
 }
 FeatureSwitch* FeatureSwitch::easy_off_store_install() {
   return &g_common_switches.Get().easy_off_store_install;
 }
 FeatureSwitch* FeatureSwitch::global_commands() {
   return &g_common_switches.Get().global_commands;
 }
 FeatureSwitch* FeatureSwitch::prompt_for_external_extensions() {
   return &g_common_switches.Get().prompt_for_external_extensions;
 }
 FeatureSwitch* FeatureSwitch::error_console() {
   return &g_common_switches.Get().error_console;
 }
 FeatureSwitch* FeatureSwitch::enable_override_bookmarks_ui() {
   return &g_common_switches.Get().enable_override_bookmarks_ui;
 }
-
+FeatureSwitch* FeatureSwitch::extension_action_redesign() {
+  return &g_common_switches.Get().extension_action_redesign;
+}
 FeatureSwitch* FeatureSwitch::scripts_require_action() {
   return &g_common_switches.Get().scripts_require_action;
 }
 
 FeatureSwitch::ScopedOverride::ScopedOverride(FeatureSwitch* feature,
                                               bool override_value)
     : feature_(feature),
       previous_value_(feature->GetOverrideValue()) {
   feature_->SetOverrideValue(
       override_value ? OVERRIDE_ENABLED : OVERRIDE_DISABLED);
@@ skipping 61 matching lines @@
 
 void FeatureSwitch::SetOverrideValue(OverrideValue override_value) {
   override_value_ = override_value;
 }
 
 FeatureSwitch::OverrideValue FeatureSwitch::GetOverrideValue() const {
   return override_value_;
 }
 
 }  // namespace extensions