Rename FLAGS_enable_quic_connection_flow_control to FLAGS_enable_quic_connection_flow_control_2, an…

Rename FLAGS_enable_quic_connection_flow_control to FLAGS_enable_quic_connection_flow_control_2, and set it to true.

Merge internal change: 69327440

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278117

[ramant (doing other things), 2014-06-17 19:20:42]

lgtm

Thanks for doing this.

[Robbie Shade, 2014-06-17 19:21:01]

The CQ bit was checked by rjshade@google.com

[Robbie Shade, 2014-06-17 19:21:47]

The CQ bit was unchecked by rjshade@google.com

[commit-bot: I haz the power, 2014-06-17 19:21:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rjshade@google.com/324283004/1

[ramant (doing other things), 2014-06-17 21:58:56]

https://codereview.chromium.org/324283004/diff/1/net/quic/quic_session_test.cc
File net/quic/quic_session_test.cc (right):

https://codereview.chromium.org/324283004/diff/1/net/quic/quic_session_test.c...
net/quic/quic_session_test.cc:687: FLAGS_enable_quic_stream_flow_control_2 =
true;
hi rjshade,
  This CL would have conflicts with the following CL. We need to restore the
FLAGs old value after the unit test (because they are globals).

https://codereview.chromium.org/330333006/diff/120001/net/quic/quic_session_t...

ValueRestore<bool> old_flag2(&FLAGS_enable_quic_stream_flow_control_2, true);
ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control, true);

[Robbie Shade, 2014-06-17 22:06:18]

I will hold off committing until https://codereview.chromium.org/330333006/ is
in.

https://codereview.chromium.org/324283004/diff/1/net/quic/quic_session_test.cc
File net/quic/quic_session_test.cc (right):

https://codereview.chromium.org/324283004/diff/1/net/quic/quic_session_test.c...
net/quic/quic_session_test.cc:687: FLAGS_enable_quic_stream_flow_control_2 =
true;
On 2014/06/17 21:58:56, ramant wrote:
> hi rjshade,
>   This CL would have conflicts with the following CL. We need to restore the
> FLAGs old value after the unit test (because they are globals).
> 
>
https://codereview.chromium.org/330333006/diff/120001/net/quic/quic_session_t...
> 
> ValueRestore<bool> old_flag2(&FLAGS_enable_quic_stream_flow_control_2, true);
> ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control, true);

Done.

[Robbie Shade, 2014-06-18 15:22:05]

ramant: PTAL, this is now up to date after
https://codereview.chromium.org/330333006/ was committed.

[ramant (doing other things), 2014-06-18 16:59:53]

lgtm

[ramant (doing other things), 2014-06-18 16:59:57]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-06-18 17:01:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rjshade@google.com/324283004/50002

[commit-bot: I haz the power, 2014-06-18 17:53:04]

Change committed as 278117