Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: net/quic/quic_session_test.cc

Issue 324283004: Rename FLAGS_enable_quic_connection_flow_control to FLAGS_enable_quic_connection_flow_control_2, an… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minimizing diffs Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/reliable_quic_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_session_test.cc
diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc
index b3250a7269ee9db590550371866eeab0ca84aeeb..d463401cb05d1570393eebec633ea0425de9a473 100644
--- a/net/quic/quic_session_test.cc
+++ b/net/quic/quic_session_test.cc
@@ -521,7 +521,8 @@ TEST_P(QuicSessionTest, OnCanWriteLimitsNumWritesIfFlowControlBlocked) {
return;
}
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control, true);
+ ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
+ true);
// Ensure connection level flow control blockage.
QuicFlowControllerPeer::SetSendWindowOffset(session_.flow_controller(), 0);
EXPECT_TRUE(session_.flow_controller()->IsBlocked());
@@ -670,7 +671,8 @@ TEST_P(QuicSessionTest, ConnectionFlowControlAccountingRstOutOfOrder) {
}
ValueRestore<bool> old_flag2(&FLAGS_enable_quic_stream_flow_control_2, true);
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control, true);
+ ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
+ true);
// Test that when we receive an out of order stream RST we correctly adjust
// our connection level flow control receive window.
// On close, the stream should mark as consumed all bytes between the highest
@@ -698,7 +700,8 @@ TEST_P(QuicSessionTest, ConnectionFlowControlAccountingFinAndLocalReset) {
}
ValueRestore<bool> old_flag2(&FLAGS_enable_quic_stream_flow_control_2, true);
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control, true);
+ ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
+ true);
// Test the situation where we receive a FIN on a stream, and before we fully
// consume all the data from the sequencer buffer we locally RST the stream.
// The bytes between highest consumed byte, and the final byte offset that we
@@ -739,7 +742,8 @@ TEST_P(QuicSessionTest, ConnectionFlowControlAccountingFinAfterRst) {
}
ValueRestore<bool> old_flag2(&FLAGS_enable_quic_stream_flow_control_2, true);
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control, true);
+ ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
+ true);
// Connection starts with some non-zero highest received byte offset,
// due to other active streams.
const uint64 kInitialConnectionBytesConsumed = 567;
@@ -783,7 +787,8 @@ TEST_P(QuicSessionTest, ConnectionFlowControlAccountingRstAfterRst) {
}
ValueRestore<bool> old_flag2(&FLAGS_enable_quic_stream_flow_control_2, true);
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control, true);
+ ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
+ true);
// Connection starts with some non-zero highest received byte offset,
// due to other active streams.
const uint64 kInitialConnectionBytesConsumed = 567;
@@ -819,7 +824,8 @@ TEST_P(QuicSessionTest, FlowControlWithInvalidFinalOffset) {
return;
}
ValueRestore<bool> old_flag2(&FLAGS_enable_quic_stream_flow_control_2, true);
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control, true);
+ ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
+ true);
const uint64 kLargeOffset = kInitialFlowControlWindowForTest + 1;
EXPECT_CALL(*connection_,
@@ -846,7 +852,8 @@ TEST_P(QuicSessionTest, VersionNegotiationDisablesFlowControl) {
}
ValueRestore<bool> old_flag2(&FLAGS_enable_quic_stream_flow_control_2, true);
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control, true);
+ ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
+ true);
// Test that after successful version negotiation, flow control is disabled
// appropriately at both the connection and stream level.
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/reliable_quic_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698