Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: ipc/message_filter.h

Issue 324143002: Decouple IPC::MessageFilter from IPC::Channel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing compilation errors Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_sync_message_filter.cc ('k') | ipc/message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/message_filter.h
diff --git a/ipc/message_filter.h b/ipc/message_filter.h
index 0371585536630ec819217c67b0d8b375b1f71b25..cfedc087b9e2eb14882ed547daa5ae198318cbee 100644
--- a/ipc/message_filter.h
+++ b/ipc/message_filter.h
@@ -12,7 +12,7 @@
namespace IPC {
-class Channel;
+class Sender;
class Message;
// A class that receives messages on the thread where the IPC channel is
@@ -25,7 +25,7 @@ class IPC_EXPORT MessageFilter
// Called on the background thread to provide the filter with access to the
// channel. Called when the IPC channel is initialized or when AddFilter
// is called if the channel is already initialized.
- virtual void OnFilterAdded(Channel* channel);
+ virtual void OnFilterAdded(Sender* sender);
// Called on the background thread when the filter has been removed from
// the ChannelProxy and when the Channel is closing. After a filter is
@@ -34,15 +34,15 @@ class IPC_EXPORT MessageFilter
// Called to inform the filter that the IPC channel is connected and we
// have received the internal Hello message from the peer.
- virtual void OnChannelConnected(int32 peer_pid);
+ virtual void OnSenderConnected();
darin (slow to review) 2014/06/10 19:39:15 I think it is a bit awkward to use the term Sender
// Called when there is an error on the channel, typically that the channel
// has been closed.
- virtual void OnChannelError();
+ virtual void OnSenderError();
// Called to inform the filter that the IPC channel will be destroyed.
// OnFilterRemoved is called immediately after this.
- virtual void OnChannelClosing();
+ virtual void OnSenderClosing();
// Return true to indicate that the message was handled, or false to let
// the message be handled in the default way.
« no previous file with comments | « ipc/ipc_sync_message_filter.cc ('k') | ipc/message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698