Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: ipc/ipc_sync_message_filter.cc

Issue 324143002: Decouple IPC::MessageFilter from IPC::Channel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing compilation errors Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_sync_message_filter.cc
diff --git a/ipc/ipc_sync_message_filter.cc b/ipc/ipc_sync_message_filter.cc
index 3833d2b20574d62f493b47217f566bd9527a9121..2c23b83cf38524b28c18759f298f4751663adb70 100644
--- a/ipc/ipc_sync_message_filter.cc
+++ b/ipc/ipc_sync_message_filter.cc
@@ -17,7 +17,7 @@ using base::MessageLoopProxy;
namespace IPC {
SyncMessageFilter::SyncMessageFilter(base::WaitableEvent* shutdown_event)
- : channel_(NULL),
+ : sender_(NULL),
listener_loop_(MessageLoopProxy::current()),
shutdown_event_(shutdown_event) {
}
@@ -67,19 +67,19 @@ bool SyncMessageFilter::Send(Message* message) {
return pending_message.send_result;
}
-void SyncMessageFilter::OnFilterAdded(Channel* channel) {
- channel_ = channel;
+void SyncMessageFilter::OnFilterAdded(Sender* sender) {
+ sender_ = sender;
base::AutoLock auto_lock(lock_);
io_loop_ = MessageLoopProxy::current();
}
-void SyncMessageFilter::OnChannelError() {
- channel_ = NULL;
+void SyncMessageFilter::OnSenderError() {
+ sender_ = NULL;
SignalAllEvents();
}
-void SyncMessageFilter::OnChannelClosing() {
- channel_ = NULL;
+void SyncMessageFilter::OnSenderClosing() {
+ sender_ = NULL;
SignalAllEvents();
}
@@ -104,8 +104,8 @@ SyncMessageFilter::~SyncMessageFilter() {
}
void SyncMessageFilter::SendOnIOThread(Message* message) {
- if (channel_) {
- channel_->Send(message);
+ if (sender_) {
+ sender_->Send(message);
return;
}
« no previous file with comments | « ipc/ipc_sync_message_filter.h ('k') | ipc/message_filter.h » ('j') | ipc/message_filter.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698