Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 32403002: Fix GrProgramsTest to not generate tests with too many TexCoord references (Closed)

Created:
7 years, 2 months ago by Kimmo Kinnunen
Modified:
7 years, 2 months ago
Reviewers:
Chris Dalton, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix GrProgramsTest to not generate tests with too many TexCoord references Make GrProgramsTest check how many texture coordinate sets are available and select random effects up until the amount runs out. Otherwise, following effect sequence would fail the shader compilation when Skia is compiled with nv_path_rendering on (eg. when fixed function codepath is used): * Stage 0: TextureDomain (1 texcoord) * Stage 1: Convolution (1 texcoord) * Stage 2: Bitmap Alpha Threshold (2 texcoords) * Stage 3: DisplacementMap (2 texcoords) * Stage 4: Config Conversion (1 texcoords) * Stage 5: Two-Point Conical Gradient (2 texcoords) This would use more texture coordinate sets than 8, which is fairly common amount currently. Committed: http://code.google.com/p/skia/source/detail?r=11881

Patch Set 1 #

Total comments: 1

Patch Set 2 : adress #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/GLProgramsTest.cpp View 3 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kimmo Kinnunen
I believe the idea was that the framework selects the effects so that any limits ...
7 years, 2 months ago (2013-10-21 12:44:57 UTC) #1
bsalomon
lgtm with one tiny nit. At this point our approach to all shader limits is ...
7 years, 2 months ago (2013-10-21 13:01:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/32403002/60001
7 years, 2 months ago (2013-10-21 13:35:54 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-21 14:48:26 UTC) #4
Message was sent while issue was closed.
Change committed as 11881

Powered by Google App Engine
This is Rietveld 408576698