Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 324013005: Make object property symbols pinnable and adjust symbol color in console. (Closed)

Created:
6 years, 6 months ago by Alexandra Mikhaylova
Modified:
6 years, 6 months ago
Reviewers:
aandrey
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make object property symbols pinnable and adjust symbol color in console. BUG=376194 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/inspector.css View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/RemoteObject.js View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexandra Mikhaylova
6 years, 6 months ago (2014-06-10 15:07:44 UTC) #1
aandrey
can you provide a screenshot?
6 years, 6 months ago (2014-06-10 15:19:23 UTC) #2
Alexandra Mikhaylova
On 2014/06/10 15:19:23, aandrey wrote: > can you provide a screenshot? sure https://drive.google.com/a/google.com/file/d/0BzUsdFEY9nf_aUMxd2hSWGRQemc/edit?usp=sharing
6 years, 6 months ago (2014-06-10 15:23:21 UTC) #3
aandrey
lgtm
6 years, 6 months ago (2014-06-10 15:40:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amikhaylova@google.com/324013005/1
6 years, 6 months ago (2014-06-10 15:41:06 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 16:46:24 UTC) #6
Message was sent while issue was closed.
Change committed as 175901

Powered by Google App Engine
This is Rietveld 408576698