Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: Source/devtools/front_end/sdk/RemoteObject.js

Issue 324013005: Make object property symbols pinnable and adjust symbol color in console. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/inspector.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/RemoteObject.js
diff --git a/Source/devtools/front_end/sdk/RemoteObject.js b/Source/devtools/front_end/sdk/RemoteObject.js
index 8584146e9adde85269afce1f0f82c35579337414..aadeb95b8730d9fc33b45723f9fbe5162c520746 100644
--- a/Source/devtools/front_end/sdk/RemoteObject.js
+++ b/Source/devtools/front_end/sdk/RemoteObject.js
@@ -334,8 +334,9 @@ WebInspector.RemoteObjectImpl.prototype = {
for (var i = 0; properties && i < properties.length; ++i) {
var property = properties[i];
var propertyValue = property.value ? this._target.runtimeModel.createRemoteObject(property.value) : null;
+ var propertySymbol = property.symbol ? this._target.runtimeModel.createRemoteObject(property.symbol) : null;
var remoteProperty = new WebInspector.RemoteObjectProperty(property.name, propertyValue,
- !!property.enumerable, !!property.writable, !!property.isOwn, !!property.wasThrown);
+ !!property.enumerable, !!property.writable, !!property.isOwn, !!property.wasThrown, propertySymbol);
if (typeof property.value === "undefined") {
if (property.get && property.get.type !== "undefined")
@@ -721,8 +722,9 @@ WebInspector.ScopeRef = function(number, callFrameId, functionId)
* @param {boolean=} writable
* @param {boolean=} isOwn
* @param {boolean=} wasThrown
+ * @param {?WebInspector.RemoteObject=} symbol
*/
-WebInspector.RemoteObjectProperty = function(name, value, enumerable, writable, isOwn, wasThrown)
+WebInspector.RemoteObjectProperty = function(name, value, enumerable, writable, isOwn, wasThrown, symbol)
{
this.name = name;
if (value !== null)
@@ -731,6 +733,8 @@ WebInspector.RemoteObjectProperty = function(name, value, enumerable, writable,
this.writable = typeof writable !== "undefined" ? writable : true;
this.isOwn = !!isOwn;
this.wasThrown = !!wasThrown;
+ if (symbol)
+ this.symbol = symbol;
}
WebInspector.RemoteObjectProperty.prototype = {
« no previous file with comments | « Source/devtools/front_end/inspector.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698