Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 324013003: Block mixed PingLoader requests. (Closed)

Created:
6 years, 6 months ago by Mike West
Modified:
6 years, 6 months ago
Reviewers:
Tom Sepez
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Block mixed PingLoader requests. We should block HTTP requests in an HTTPS context whenever possible. Pings are practically zero-impact to users, so blocking them via a mixed content warning is very low risk. Mozilla is making the same change: https://hg.mozilla.org/try/rev/5a9f4d5a8707 BUG=382798 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176681

Patch Set 1 #

Patch Set 2 : Results. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M LayoutTests/http/tests/navigation/ping-cross-origin-from-https.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/ping-cross-origin-from-https-expected.txt View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
A + LayoutTests/http/tests/navigation/resources/ping-cross-origin-from-https-target.html View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/loader/PingLoader.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Mike West
WDYT, Tom? -mike
6 years, 6 months ago (2014-06-10 12:21:47 UTC) #1
Tom Sepez
On 2014/06/10 12:21:47, Mike West wrote: > WDYT, Tom? > > -mike Can we separate ...
6 years, 6 months ago (2014-06-10 18:12:46 UTC) #2
Mike West
On 2014/06/10 at 18:12:46, tsepez wrote: > On 2014/06/10 12:21:47, Mike West wrote: > > ...
6 years, 6 months ago (2014-06-10 18:50:05 UTC) #3
Mike West
Mind taking another look, Tom? I landed the deflake portion a few days ago... -mike
6 years, 6 months ago (2014-06-20 14:54:03 UTC) #4
Tom Sepez
lgtm
6 years, 6 months ago (2014-06-20 22:14:16 UTC) #5
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 6 months ago (2014-06-21 03:22:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/324013003/40001
6 years, 6 months ago (2014-06-21 03:24:07 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-21 04:26:43 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-21 04:38:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13022)
6 years, 6 months ago (2014-06-21 04:38:19 UTC) #10
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 6 months ago (2014-06-21 07:29:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/324013003/40001
6 years, 6 months ago (2014-06-21 07:30:42 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-21 09:21:05 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-21 10:09:19 UTC) #14
Message was sent while issue was closed.
Change committed as 176681

Powered by Google App Engine
This is Rietveld 408576698