Use labels to display views tab titles.

Use labels to display views tab titles.

Add a Label view to Tab for displaying the title.
Remove Tab::PaintTitle, bounds and font members.
Remove unnecessary Tab::Get[Title|Icon]Bounds helpers.
Update the text on Tab::SetData, not during paint.
Use gfx::DirectionalityMode, remove the Label enum.

Add gfx::ALIGN_TO_HEAD to gfx::HorizontalAlignment.
Add Label::GetHorizontalAlignment for ALIGN_TO_HEAD.
Always flip left/right in Label::SetHorizontalAlignment.
Have Tab and MessageBoxView use ALIGN_TO_HEAD.

Update comments and tests, related minor cleanup.

TODO: Make Label cache RenderText objects.
TODO: Make RenderText support ALIGN_TO_HEAD.

BUG=240037
TEST=No visible Views tab title changes.
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276450

[msw, 2014-06-10 18:46:01]

Hey Scott, please take a look; thanks.
Note that I plan to do a Label rewrite soon.

[sky, 2014-06-10 19:37:10]

https://codereview.chromium.org/323993002/diff/40001/chrome/browser/ui/views/...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/323993002/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/tabs/tab.cc:407: title_ = new views::Label();
move to member initializer.

https://codereview.chromium.org/323993002/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/tabs/tab.cc:803:
title_->SetX(GetMirroredXForRect(title_->bounds()));
Is it possible to do this in a single step? Otherwise even if the resulting
bounds end up the same I believe you'll trigger some unnecessary painting
because of the intermediary bounds.

[msw, 2014-06-11 03:57:12]

Please take another look; thanks!

https://codereview.chromium.org/323993002/diff/40001/chrome/browser/ui/views/...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/323993002/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/tabs/tab.cc:407: title_ = new views::Label();
On 2014/06/10 19:37:10, sky wrote:
> move to member initializer.

Done.

https://codereview.chromium.org/323993002/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/tabs/tab.cc:803:
title_->SetX(GetMirroredXForRect(title_->bounds()));
On 2014/06/10 19:37:10, sky wrote:
> Is it possible to do this in a single step? Otherwise even if the resulting
> bounds end up the same I believe you'll trigger some unnecessary painting
> because of the intermediary bounds.

Done.

[sky, 2014-06-11 15:58:02]

LGTM

[msw, 2014-06-11 16:39:11]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-06-11 16:40:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/323993002/60001

[commit-bot: I haz the power, 2014-06-11 18:04:28]

Change committed as 276450

[please use gerrit instead, 2014-06-11 19:27:46]

A revert of this CL has been created in
https://codereview.chromium.org/327273005/ by rouslan@chromium.org.

The reason for reverting is: Appears to have a memory leak. See:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....