ui/message_center/views/bounded_label.cc - Issue 323993002: Use labels to display views tab titles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/views/bounded_label.cc

Issue 323993002: Use labels to display views tab titles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments; update tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/message_center/views/bounded_label.cc

diff --git a/ui/message_center/views/bounded_label.cc b/ui/message_center/views/bounded_label.cc

index 0acad8e22027f3b3da2036cd5d9fefd5614f1592..99c66f80b77c51d9594f815115f5f15e49b6fff8 100644

--- a/ui/message_center/views/bounded_label.cc

+++ b/ui/message_center/views/bounded_label.cc

@@ -198,8 +198,11 @@ int InnerBoundedLabel::GetTextFlags() {

if (SkColorGetA(background_color()) != 0xFF)

flags |= gfx::Canvas::NO_SUBPIXEL_RENDERING;

- if (directionality_mode() ==

- views::Label::AUTO_DETECT_DIRECTIONALITY) {

+ if (directionality_mode() == gfx::DIRECTIONALITY_FORCE_LTR) {

+ flags |= gfx::Canvas::FORCE_LTR_DIRECTIONALITY;

+ } else if (directionality_mode() == gfx::DIRECTIONALITY_FORCE_RTL) {

+ flags |= gfx::Canvas::FORCE_RTL_DIRECTIONALITY;

+ } else if (directionality_mode() == gfx::DIRECTIONALITY_FROM_TEXT) {

base::i18n::TextDirection direction =

base::i18n::GetFirstStrongCharacterDirection(text());

if (direction == base::i18n::RIGHT_TO_LEFT)

« no previous file with comments | « ui/gfx/text_constants.h ('k') | ui/views/controls/button/label_button.cc » ('j') | no next file with comments »