Support for recording registered LSPs

chrome/common/safe_browsing/csd.proto

Index: chrome/common/safe_browsing/csd.proto
diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto
index a04147a28a31b27c9318aded6e623e6a3e4b0422..7d9feaeb27feb60871967f209e7436339cb25a63 100644
--- a/chrome/common/safe_browsing/csd.proto
+++ b/chrome/common/safe_browsing/csd.proto
@@ -110,7 +110,7 @@ message ClientMalwareRequest {
     required string url = 2;
     optional string method = 3;
     optional string referrer = 4;
-    // Resource type, the int value is a direct cast from the Type enum 
+    // Resource type, the int value is a direct cast from the Type enum
     // of ResourceType class defined in //src/webkit/commom/resource_type.h
     optional int32 resource_type = 5;
   }
@@ -380,7 +380,17 @@ message ClientIncidentReport {
     optional Machine machine = 2;
     message Process {
       optional string version = 1;
-      repeated string dlls = 2;

[grt (UTC plus 2), 2014/06/10 20:57:53]

rather than change field #2 from a repeated string to a repeated message, please
put OBSOLETE_ in front of this field and make your new repeated field #9 (i'm
adding 7 and 8 to my CL) and move it down so that it appears after #6.

[pmonette_google.com, 2014/06/10 21:39:04]

Done.

+      message Dll {
+        enum Feature {
+          UNKNOWN = 0;
+          LSP = 1;
+        }
+        optional string path = 1;
+        optional int64 base_address = 2;

[grt (UTC plus 2), 2014/06/10 20:57:54]

i checked the underlying file format and confirmed that this is an unsigned
32-bit value even on 64-bit images, so uint32 here as well. thanks.

[pmonette_google.com, 2014/06/10 21:39:04]

Done.

+        optional int32 length = 3;

[grt (UTC plus 2), 2014/06/10 20:57:54]

uint32 since this is unsigned

[pmonette_google.com, 2014/06/10 21:39:04]

Done.

+        repeated Feature features = 4;

[grt (UTC plus 2), 2014/06/10 20:57:54]

i just noticed that the protobuf style guide says to use singular form for
repeated fields, so please rename this from "features" to "feature".

[pmonette_google.com, 2014/06/10 21:39:04]

Done.

+      }
+      repeated Dll dlls = 2;

[grt (UTC plus 2), 2014/06/10 20:57:53]

dlls -> dll

[pmonette_google.com, 2014/06/10 21:39:04]

Done.

       message Patch {
         optional string function = 1;
         optional string target_dll = 2;