Support for recording registered LSPs

chrome/common/safe_browsing/csd.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Client side phishing and malware detection request and response
 // protocol buffers.  Those protocol messages should be kept in sync
 // with the server implementation.
 //
 // If you want to change this protocol definition or you have questions
 // regarding its format please contact chrome-anti-phishing@googlegroups.com.
@@ skipping 92 matching lines @@
   // where the referrer uses HTTPS.
   optional string referrer_url = 4;
 
   // Field 5 and 6 are only used on the server.
 
   message UrlInfo {
     required string ip = 1;
     required string url = 2;
     optional string method = 3;
     optional string referrer = 4;
-    // Resource type, the int value is a direct cast from the Type enum 
+    // Resource type, the int value is a direct cast from the Type enum
     // of ResourceType class defined in //src/webkit/commom/resource_type.h
     optional int32 resource_type = 5;
   }
 
   // List of resource urls that match the malware IP list.
   repeated UrlInfo bad_ip_url_info = 7;
 }
 
 message ClientMalwareResponse {
   required bool blacklist = 1;
@@ skipping 249 matching lines @@
     }
     optional OS os = 1;
     message Machine {
       optional string cpu_architecture = 1;
       optional string cpu_vendor = 2;
       optional uint32 cpuid = 3;
     }
     optional Machine machine = 2;
     message Process {
       optional string version = 1;
-      repeated string dlls = 2;

[grt (UTC plus 2), 2014/06/10 20:57:53]

rather than change field #2 from a repeated string to a repeated message, please
put OBSOLETE_ in front of this field and make your new repeated field #9 (i'm
adding 7 and 8 to my CL) and move it down so that it appears after #6.

[pmonette_google.com, 2014/06/10 21:39:04]

Done.

+      message Dll {
+        enum Feature {
+          UNKNOWN = 0;
+          LSP = 1;
+        }
+        optional string path = 1;
+        optional int64 base_address = 2;

[grt (UTC plus 2), 2014/06/10 20:57:54]

i checked the underlying file format and confirmed that this is an unsigned
32-bit value even on 64-bit images, so uint32 here as well. thanks.

[pmonette_google.com, 2014/06/10 21:39:04]

Done.

+        optional int32 length = 3;

[grt (UTC plus 2), 2014/06/10 20:57:54]

uint32 since this is unsigned

[pmonette_google.com, 2014/06/10 21:39:04]

Done.

+        repeated Feature features = 4;

[grt (UTC plus 2), 2014/06/10 20:57:54]

i just noticed that the protobuf style guide says to use singular form for
repeated fields, so please rename this from "features" to "feature".

[pmonette_google.com, 2014/06/10 21:39:04]

Done.

+      }
+      repeated Dll dlls = 2;

[grt (UTC plus 2), 2014/06/10 20:57:53]

dlls -> dll

[pmonette_google.com, 2014/06/10 21:39:04]

Done.

       message Patch {
         optional string function = 1;
         optional string target_dll = 2;
       }
       repeated Patch patches = 3;
       message NetworkProvider {}
       repeated NetworkProvider network_providers = 4;
       enum Channel {
         CHANNEL_UNKNOWN = 0;
         CHANNEL_CANARY = 1;
@@ skipping 11 matching lines @@
 }
 
 message ClientIncidentResponse {
   optional bytes token = 1;
   optional bool download_requested = 2;
 
   message EnvironmentRequest { optional int32 dll_index = 1; }
 
   repeated EnvironmentRequest environment_requests = 3;
 }