Issue 323873002: Timeline: do not remove trace object snapshots from event list of their threads

Issue 323873002: Timeline: do not remove trace object snapshots from event list of their threads (Closed)

Created:
6 years, 6 months ago by caseq

Modified:
6 years, 6 months ago

Reviewers:
yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Timeline: do not remove trace object snapshots from event list of their threads We still won't draw them as events, as we check for non-zero duration, but we'd be able to process them in the TracingTimelineModel, e.g. to associate with other events and frames. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175809

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments addressed #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -9 lines)			Patch
	M	Source/devtools/front_end/timeline/TimelineTracingView.js	View	1	3 chunks	+5 lines, -4 lines	0 comments	Download
	M	Source/devtools/front_end/timeline/TracingModel.js	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/323873002/diff/1/Source/devtools/front_end/timeline/TimelineTracingView.js File Source/devtools/front_end/timeline/TimelineTracingView.js (right): https://codereview.chromium.org/323873002/diff/1/Source/devtools/front_end/timeline/TimelineTracingView.js#newcode482 Source/devtools/front_end/timeline/TimelineTracingView.js:482: _appendRecord: function(record, level) Let's always pass level value ...

6 years, 6 months ago (2014-06-09 15:26:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/323873002/20001

6 years, 6 months ago (2014-06-09 16:52:51 UTC) #4

Message was sent while issue was closed.

Change committed as 175809

Expand Messages | Collapse Messages