Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1645)

Unified Diff: Source/devtools/front_end/timeline/TracingModel.js

Issue 323873002: Timeline: do not remove trace object snapshots from event list of their threads (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments addressed Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineTracingView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TracingModel.js
diff --git a/Source/devtools/front_end/timeline/TracingModel.js b/Source/devtools/front_end/timeline/TracingModel.js
index 29fa713edf907e88d28b702087f5a119a2d45755..c327bf846063f0fc926ac7c03fa8f5b566b9d0cf 100644
--- a/Source/devtools/front_end/timeline/TracingModel.js
+++ b/Source/devtools/front_end/timeline/TracingModel.js
@@ -185,11 +185,6 @@ WebInspector.TracingModel.prototype = {
this._processById[payload.pid] = process;
}
var thread = process.threadById(payload.tid);
- if (payload.ph === WebInspector.TracingModel.Phase.SnapshotObject) {
- var event = thread.addEvent(payload);
- process.addObject(event);
- return;
- }
if (payload.ph !== WebInspector.TracingModel.Phase.Metadata) {
var timestamp = payload.ts / 1000;
// We do allow records for unrelated threads to arrive out-of-order,
@@ -199,6 +194,8 @@ WebInspector.TracingModel.prototype = {
if (!this._maximumRecordTime || timestamp > this._maximumRecordTime)
this._maximumRecordTime = timestamp;
var event = thread.addEvent(payload);
+ if (payload.ph === WebInspector.TracingModel.Phase.SnapshotObject)
+ process.addObject(event);
if (event && event.name === WebInspector.TracingModel.DevToolsMetadataEvent.TracingStartedInPage &&
event.category === WebInspector.TracingModel.DevToolsMetadataEventCategory &&
event.args["sessionId"] === this._sessionId)
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineTracingView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698