Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: tools/perf/page_sets/gmail_expand_collapse_conversation.py

Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Undo deletion of wait_until (to be done in separate patch). Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/gmail_expand_collapse_conversation.py
diff --git a/tools/perf/page_sets/gmail_expand_collapse_conversation.py b/tools/perf/page_sets/gmail_expand_collapse_conversation.py
index f223e654d794fec0f978e1feaee20536eeba0875..769bdbbea3da496190c9da8caad42abc945c9709 100644
--- a/tools/perf/page_sets/gmail_expand_collapse_conversation.py
+++ b/tools/perf/page_sets/gmail_expand_collapse_conversation.py
@@ -26,30 +26,18 @@ class GmailExpandCollapseConversationPage(
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
action_runner.WaitForElement('img[alt="Expand all"]')
- action_runner.RunAction(ClickElementAction(
- {
- 'selector': 'img[alt="Expand all"]'
- }))
+ action_runner.ClickElement('img[alt="Expand all"]')
action_runner.Wait(5)
action_runner.WaitForElement('img[alt="Collapse all"]')
- action_runner.RunAction(ClickElementAction(
- {
- 'selector': 'img[alt="Collapse all"]'
- }))
+ action_runner.ClickElement('img[alt="Collapse all"]')
action_runner.Wait(1)
def RunEndure(self, action_runner):
action_runner.WaitForElement('img[alt="Expand all"]')
- action_runner.RunAction(ClickElementAction(
- {
- 'selector': 'img[alt="Expand all"]'
- }))
+ action_runner.ClickElement('img[alt="Expand all"]')
action_runner.Wait(1)
action_runner.WaitForElement('img[alt="Collapse all"]')
- action_runner.RunAction(ClickElementAction(
- {
- 'selector': 'img[alt="Collapse all"]'
- }))
+ action_runner.ClickElement('img[alt="Collapse all"]')
action_runner.Wait(1)

Powered by Google App Engine
This is Rietveld 408576698