tools/perf/page_sets/gmail_compose_discard.py - Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/gmail_compose_discard.py

Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Undo deletion of wait_until (to be done in separate patch). Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/page_sets/gmail_alt_two_labels.py ('k') | tools/perf/page_sets/gmail_expand_collapse_conversation.py » ('j') | tools/perf/page_sets/key_silk_cases.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/page_sets/gmail_compose_discard.py

diff --git a/tools/perf/page_sets/gmail_compose_discard.py b/tools/perf/page_sets/gmail_compose_discard.py

index 018dd9eec9968b4e989a574b3d14fe7a3aeaff2e..1d9c03da62aba8412cbe6d423b855b830e28b284 100644

--- a/tools/perf/page_sets/gmail_compose_discard.py

+++ b/tools/perf/page_sets/gmail_compose_discard.py

@@ -11,9 +11,12 @@ from telemetry.page import page_set as page_set_module

def _CreateXpathFunction(xpath):

- return ('document.evaluate(%s, document, null, '

- 'XPathResult.FIRST_ORDERED_NODE_TYPE, null)'

- '.singleNodeEvaluate') % re.escape(xpath)

+ return ('document.evaluate("%s",'

+ 'document,'

+ 'null,'

+ 'XPathResult.FIRST_ORDERED_NODE_TYPE,'

+ 'null)'

+ '.singleNodeValue' % re.escape(xpath))

class GmailComposeDiscardPage(page_module.Page):

@@ -53,10 +56,7 @@ class GmailComposeDiscardPage(page_module.Page):

action_runner.Wait(1)

action_runner.WaitForElement(

'div[class~="oh"][data-tooltip="Discard draft"]')

- action_runner.RunAction(ClickElementAction(

- {

- 'selector': 'div[class~="oh"][data-tooltip="Discard draft"]'

- }))

+ action_runner.ClickElement('div[class~="oh"][data-tooltip="Discard draft"]')

action_runner.Wait(1)