Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1784)

Unified Diff: net/base/file_stream.cc

Issue 323683002: net: FileStream cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add DCHECK, fix ASSERT message Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/file_stream.cc
diff --git a/net/base/file_stream.cc b/net/base/file_stream.cc
index bf56a49e8c011ea7907d68c4268cd6d5e0e2838b..cadbaed663edd83fc758056ebf9d809b8661df84 100644
--- a/net/base/file_stream.cc
+++ b/net/base/file_stream.cc
@@ -30,12 +30,12 @@ int FileStream::Open(const base::FilePath& path, int open_flags,
}
DCHECK(open_flags & base::File::FLAG_ASYNC);
- context_->OpenAsync(path, open_flags, callback);
+ context_->Open(path, open_flags, callback);
return ERR_IO_PENDING;
}
int FileStream::Close(const CompletionCallback& callback) {
- context_->CloseAsync(callback);
+ context_->Close(callback);
return ERR_IO_PENDING;
}
@@ -43,13 +43,13 @@ bool FileStream::IsOpen() const {
return context_->file().IsValid();
}
-int FileStream::Seek(Whence whence,
+int FileStream::Seek(base::File::Whence whence,
int64 offset,
const Int64CompletionCallback& callback) {
if (!IsOpen())
return ERR_UNEXPECTED;
- context_->SeekAsync(whence, offset, callback);
+ context_->Seek(whence, offset, callback);
return ERR_IO_PENDING;
}
@@ -62,7 +62,7 @@ int FileStream::Read(IOBuffer* buf,
// read(..., 0) will return 0, which indicates end-of-file.
DCHECK_GT(buf_len, 0);
- return context_->ReadAsync(buf, buf_len, callback);
+ return context_->Read(buf, buf_len, callback);
}
int FileStream::Write(IOBuffer* buf,
@@ -71,17 +71,15 @@ int FileStream::Write(IOBuffer* buf,
if (!IsOpen())
return ERR_UNEXPECTED;
- // write(..., 0) will return 0, which indicates end-of-file.
- DCHECK_GT(buf_len, 0);
-
- return context_->WriteAsync(buf, buf_len, callback);
+ DCHECK_GE(buf_len, 0);
+ return context_->Write(buf, buf_len, callback);
}
int FileStream::Flush(const CompletionCallback& callback) {
if (!IsOpen())
return ERR_UNEXPECTED;
- context_->FlushAsync(callback);
+ context_->Flush(callback);
return ERR_IO_PENDING;
}

Powered by Google App Engine
This is Rietveld 408576698