Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2038)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/files/file_posix.cc

Issue 323683002: net: FileStream cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More comments, fix init typo Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/files/file_unittest.cc » ('j') | net/base/file_stream.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file_posix.cc
diff --git a/base/files/file_posix.cc b/base/files/file_posix.cc
index 0764ee98660239ed813ada6d0dd0a7b15429aeee..4451210eca5d457ceafd5022714ebbf97b69b53c 100644
--- a/base/files/file_posix.cc
+++ b/base/files/file_posix.cc
@@ -280,8 +280,6 @@ void File::Close() {
int64 File::Seek(Whence whence, int64 offset) {
base::ThreadRestrictions::AssertIOAllowed();
DCHECK(IsValid());
- if (offset < 0)
- return -1;
return lseek(file_.get(), static_cast<off_t>(offset),
wtc 2014/06/16 23:01:44 We should assert that sizeof(off_t) == 8. If sizeo
rvargas (doing something else) 2014/06/18 01:36:38 Done.
static_cast<int>(whence));
« no previous file with comments | « no previous file | base/files/file_unittest.cc » ('j') | net/base/file_stream.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698