net: FileStream cleanup

base/files/file_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <sys/stat.h>
 #include <unistd.h>
@@ skipping 262 matching lines @@
   if (!IsValid())
     return;
 
   base::ThreadRestrictions::AssertIOAllowed();
   file_.reset();
 }
 
 int64 File::Seek(Whence whence, int64 offset) {
   base::ThreadRestrictions::AssertIOAllowed();
   DCHECK(IsValid());
-  if (offset < 0)
-    return -1;
 
   return lseek(file_.get(), static_cast<off_t>(offset),

[wtc, 2014/06/16 23:01:44]

We should assert that sizeof(off_t) == 8. If sizeof(off_t) is 4, this
static_cast<off_t> will truncate |offset|.

[rvargas (doing something else), 2014/06/18 01:36:38]

Done.

                static_cast<int>(whence));
 }
 
 int File::Read(int64 offset, char* data, int size) {
   base::ThreadRestrictions::AssertIOAllowed();
   DCHECK(IsValid());
   if (size < 0)
     return -1;
 
   int bytes_read = 0;
@@ skipping 182 matching lines @@
       return FILE_ERROR_FAILED;
   }
 }
 
 void File::SetPlatformFile(PlatformFile file) {
   DCHECK(!file_.is_valid());
   file_.reset(file);
 }
 
 }  // namespace base