Issue 323563004: fix crash when identity.getAuthToken is called without an options parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 323563004: fix crash when identity.getAuthToken is called without an options parameter (Closed)

Created:
6 years, 6 months ago by Michael Courage

Modified:
6 years, 6 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

fix crash when identity.getAuthToken is called without an options parameter This change updates the multi-account handling code to make sure the options parameter object is present before dereferencing it to find the "account" field. A new browser test calls getAuthToken without options. BUG=381637 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275587

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
	M	chrome/browser/extensions/api/identity/identity_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/extensions/api/identity/identity_apitest.cc	View		1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/323563004/1

6 years, 6 months ago (2014-06-06 21:10:45 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...

6 years, 6 months ago (2014-06-07 00:41:09 UTC) #5

Message was sent while issue was closed.

Change committed as 275587

Expand Messages | Collapse Messages