chrome/browser/extensions/api/identity/identity_api.cc - Issue 323563004: fix crash when identity.getAuthToken is called without an options parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_api.cc

Issue 323563004: fix crash when identity.getAuthToken is called without an options parameter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/identity/identity_api.cc

diff --git a/chrome/browser/extensions/api/identity/identity_api.cc b/chrome/browser/extensions/api/identity/identity_api.cc

index 17c973a1504d8baadbf6beafbbd2844f47a6a86c..3b9ba354af618a1f76338ee8930bddf2b1cce099 100644

--- a/chrome/browser/extensions/api/identity/identity_api.cc

+++ b/chrome/browser/extensions/api/identity/identity_api.cc

@@ -325,7 +325,7 @@ bool IdentityGetAuthTokenFunction::RunAsync() {

std::string account_key = GetPrimaryAccountId(GetProfile());

- if (params->details->account.get()) {

+ if (params->details.get() && params->details->account.get()) {

std::string detail_key =

extensions::IdentityAPI::GetFactoryInstance()

->Get(GetProfile())

« no previous file with comments | « no previous file | chrome/browser/extensions/api/identity/identity_apitest.cc » ('j') | no next file with comments »