Issue 323523004: DevTools: Add scripts sourceURL plumbing from v8.

Issue 323523004: DevTools: Add scripts sourceURL plumbing from v8. (Closed)

Created:
6 years, 6 months ago by vsevik

Modified:
6 years, 5 months ago

Reviewers:
yurys, pfeldman

CC:
marja, blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Add scripts sourceURL plumbing from v8. BUG=v8:2948 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178389

Patch Set 1 #

Patch Set 2 : Rebaselined #

Total comments: 1

Patch Set 3 : Comments addressed #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -21 lines)			Patch
M	Source/bindings/core/v8/DebuggerScript.js	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/bindings/core/v8/ScriptDebugServer.cpp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorDebuggerAgent.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorDebuggerAgent.cpp	View	1 2	2 chunks	+28 lines, -18 lines	0 comments	Download
M	Source/core/inspector/ScriptDebugListener.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

vsevik

I have rebaselined this to support the new scenario of script with compile errors. Could ...

6 years, 5 months ago (2014-07-17 13:44:21 UTC) #3

yurys

https://codereview.chromium.org/323523004/diff/20001/Source/core/inspector/InspectorDebuggerAgent.cpp File Source/core/inspector/InspectorDebuggerAgent.cpp (right): https://codereview.chromium.org/323523004/diff/20001/Source/core/inspector/InspectorDebuggerAgent.cpp#newcode1213 Source/core/inspector/InspectorDebuggerAgent.cpp:1213: script.sourceURL = String(); I don't like that we modify ...

6 years, 5 months ago (2014-07-17 14:05:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/323523004/40001

6 years, 5 months ago (2014-07-17 16:24:15 UTC) #7

Message was sent while issue was closed.

Change committed as 178389

Expand Messages | Collapse Messages