Source/bindings/core/v8/ScriptDebugServer.cpp - Issue 323523004: DevTools: Add scripts sourceURL plumbing from v8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.cpp

Issue 323523004: DevTools: Add scripts sourceURL plumbing from v8. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Comments addressed Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptDebugServer.cpp

diff --git a/Source/bindings/core/v8/ScriptDebugServer.cpp b/Source/bindings/core/v8/ScriptDebugServer.cpp

index 7d64484d9051206a4a6296fcca6c8a3209ae4b07..7f03a4ab56724315aa099a6b061df1c67a82e3cd 100644

--- a/Source/bindings/core/v8/ScriptDebugServer.cpp

+++ b/Source/bindings/core/v8/ScriptDebugServer.cpp

@@ -537,8 +537,9 @@ void ScriptDebugServer::dispatchDidParseSource(ScriptDebugListener* listener, v8

ScriptDebugListener::Script script;

script.url = toCoreStringWithUndefinedOrNullCheck(object->Get(v8AtomicString(m_isolate, "name")));

- script.source = toCoreStringWithUndefinedOrNullCheck(object->Get(v8AtomicString(m_isolate, "source")));

+ script.sourceURL = toCoreStringWithUndefinedOrNullCheck(object->Get(v8AtomicString(m_isolate, "sourceURL")));

script.sourceMappingURL = toCoreStringWithUndefinedOrNullCheck(object->Get(v8AtomicString(m_isolate, "sourceMappingURL")));

+ script.source = toCoreStringWithUndefinedOrNullCheck(object->Get(v8AtomicString(m_isolate, "source")));

script.startLine = object->Get(v8AtomicString(m_isolate, "startLine"))->ToInteger()->Value();

script.startColumn = object->Get(v8AtomicString(m_isolate, "startColumn"))->ToInteger()->Value();

script.endLine = object->Get(v8AtomicString(m_isolate, "endLine"))->ToInteger()->Value();