Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 323513003: Fixed DCHECK in InProcessGpuThread shutdown. (Closed)

Created:
6 years, 6 months ago by Victor Starodub
Modified:
6 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed DCHECK in InProcessGpuThread shutdown. Upon BrowserMainRunner::Shutdown(), InProcessGpuThread sometimes (race condition) terminates simply by exiting the message loop due to closed RPC channel, the ThreadWasQuitProperly flag is required to signal correct termnation in this case. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/gpu/in_process_gpu_thread.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Victor Starodub
I need this to implement desktop-like shutdown logic for content_browsertests on android. For context: https://codereview.chromium.org/311943002/ ...
6 years, 6 months ago (2014-06-06 15:45:55 UTC) #1
Ken Russell (switch to Gerrit)
This looks fine to me but sievers or aelias should look at it as this ...
6 years, 6 months ago (2014-06-06 19:51:40 UTC) #2
no sievers
lgtm
6 years, 6 months ago (2014-06-06 19:56:15 UTC) #3
Ken Russell (switch to Gerrit)
LGTM too.
6 years, 6 months ago (2014-06-06 20:00:08 UTC) #4
Victor Starodub
The CQ bit was checked by starodub@google.com
6 years, 6 months ago (2014-06-09 12:54:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/323513003/1
6 years, 6 months ago (2014-06-09 12:54:59 UTC) #6
Victor Starodub
The CQ bit was unchecked by starodub@google.com
6 years, 6 months ago (2014-06-09 16:54:16 UTC) #7
Victor Starodub
The CQ bit was checked by starodub@google.com
6 years, 6 months ago (2014-06-09 16:54:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/323513003/1
6 years, 6 months ago (2014-06-09 16:55:13 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 20:25:06 UTC) #10
Message was sent while issue was closed.
Change committed as 275848

Powered by Google App Engine
This is Rietveld 408576698