Scheme of content utils should be compared in an ASCII case-insensitive manner

Scheme of content utils should be compared in an ASCII case-insensitive manner

Scheme has been compared in case-sensitive manner. However, according to spec, scheme must be compared in an ASCII case-insensitive manner by user agents.

Merge from WebKit : http://trac.webkit.org/changeset/169670

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175771

[haraken, 2014-06-07 02:19:23]

How do other browsers (Firefox or IE) behave?

https://codereview.chromium.org/323493003/diff/1/Source/modules/navigatorcont...
File Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp (right):

https://codereview.chromium.org/323493003/diff/1/Source/modules/navigatorcont...
Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp:109:
builder.append(character);

Do we need this branch? I guess builder.append(toASCIILower(character)) works as
expected for lower characters as well.

[gyuyoung-inactive, 2014-06-07 06:28:51]

https://codereview.chromium.org/323493003/diff/1/Source/modules/navigatorcont...
File Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp (right):

https://codereview.chromium.org/323493003/diff/1/Source/modules/navigatorcont...
Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp:109:
builder.append(character);
On 2014/06/07 02:19:23, haraken wrote:
> 
> Do we need this branch? I guess builder.append(toASCIILower(character)) works
as
> expected for lower characters as well.

Doesn't this operation always call toASCIILower() function even when character
is ASCII lowercase ? Of course, it looks it is trivial overhead.

[haraken, 2014-06-07 06:36:49]

https://codereview.chromium.org/323493003/diff/1/Source/modules/navigatorcont...
File Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp (right):

https://codereview.chromium.org/323493003/diff/1/Source/modules/navigatorcont...
Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp:109:
builder.append(character);
On 2014/06/07 06:28:51, gyuyoung wrote:
> On 2014/06/07 02:19:23, haraken wrote:
> > 
> > Do we need this branch? I guess builder.append(toASCIILower(character))
works
> as
> > expected for lower characters as well.
> 
> Doesn't this operation always call toASCIILower() function even when character
> is ASCII lowercase ? Of course, it looks it is trivial overhead.

I mean, you can remove line 106 - 109 and just use
builder.append(toASCIILower(character)).

The difference is just whether you check isASCIIUpper(character) in the caller
side or the callee side.

[gyuyoung-inactive, 2014-06-07 06:51:02]

https://codereview.chromium.org/323493003/diff/1/Source/modules/navigatorcont...
File Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp (right):

https://codereview.chromium.org/323493003/diff/1/Source/modules/navigatorcont...
Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp:109:
builder.append(character);
On 2014/06/07 06:36:49, haraken wrote:
> On 2014/06/07 06:28:51, gyuyoung wrote:
> > On 2014/06/07 02:19:23, haraken wrote:
> > > 
> > > Do we need this branch? I guess builder.append(toASCIILower(character))
> works
> > as
> > > expected for lower characters as well.
> > 
> > Doesn't this operation always call toASCIILower() function even when
character
> > is ASCII lowercase ? Of course, it looks it is trivial overhead.
> 
> I mean, you can remove line 106 - 109 and just use
> builder.append(toASCIILower(character)).
> 
> The difference is just whether you check isASCIIUpper(character) in the caller
> side or the callee side.

Ah...yes. we can avoid to call isASCIIUpper() when using your suggestion.
Calling overhead looks same.

[gyuyoung-inactive, 2014-06-09 02:26:59]

On 2014/06/07 02:19:23, haraken wrote:
> How do other browsers (Firefox or IE) behave?

Kentaro, firefox supports to compare scheme in an ASCII case-insensitive manner.
However, it looks IE doesn't support this feature yet.

According to MDN, it isn't know if IE supports this feature.
https://developer.mozilla.org/en-US/docs/Web/API/navigator.registerProtocolHa...

[haraken, 2014-06-09 02:31:31]

On 2014/06/09 02:26:59, gyuyoung wrote:
> On 2014/06/07 02:19:23, haraken wrote:
> > How do other browsers (Firefox or IE) behave?
> 
> Kentaro, firefox supports to compare scheme in an ASCII case-insensitive
manner.
> However, it looks IE doesn't support this feature yet.
> 
> According to MDN, it isn't know if IE supports this feature.
>
https://developer.mozilla.org/en-US/docs/Web/API/navigator.registerProtocolHa...

Thanks, then given the spec and the behavior of firefox, it makes sense to make
this change.

LGTM.

[gyuyoung-inactive, 2014-06-09 02:32:32]

The CQ bit was checked by gyuyoung.kim@samsung.com

[commit-bot: I haz the power, 2014-06-09 02:33:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/323493003/20001

[commit-bot: I haz the power, 2014-06-09 03:41:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10769)

[commit-bot: I haz the power, 2014-06-09 04:10:09]

Change committed as 175771