Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 323343004: [SVG2] The exposed event target should be the <use> element. (Closed)

Created:
6 years, 6 months ago by Erik Dahlström (inactive)
Modified:
6 years, 6 months ago
Reviewers:
pdr., rwlbuis
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[SVG2] The exposed event target should be the <use> element. Spec: https://svgwg.org/svg2-draft/struct.html#UseElement BUG=382872, 313438 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176090

Patch Set 1 #

Patch Set 2 : tweak tests #

Patch Set 3 : rebase #

Patch Set 4 : rebased #

Patch Set 5 : rebase :P #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -34 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/resources/use-instanceRoot-event-bubbling.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
A LayoutTests/svg/custom/use-event-retargeting.html View 1 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/use-event-retargeting-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/use-instanceRoot-event-bubbling-expected.txt View 1 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/events/EventPath.cpp View 1 2 3 4 4 chunks +2 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rwlbuis
The patch seems good to me, and related to some of my other patches. Waiting ...
6 years, 6 months ago (2014-06-12 18:32:15 UTC) #1
pdr.
This is a good patch. LGTM
6 years, 6 months ago (2014-06-12 19:11:28 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-06-12 19:11:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/323343004/40001
6 years, 6 months ago (2014-06-12 19:12:42 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 19:13:05 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-12 19:13:06 UTC) #6
Erik Dahlström (inactive)
The CQ bit was checked by ed@opera.com
6 years, 6 months ago (2014-06-12 19:27:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/323343004/60001
6 years, 6 months ago (2014-06-12 19:27:37 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 21:43:41 UTC) #9
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-12 21:43:42 UTC) #10
Erik Dahlström (inactive)
The CQ bit was checked by ed@opera.com
6 years, 6 months ago (2014-06-13 07:09:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/323343004/80001
6 years, 6 months ago (2014-06-13 07:09:35 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 08:22:18 UTC) #13
Message was sent while issue was closed. 
Change committed as 176090

Powered by Google App Engine
This is Rietveld 408576698