Source/bindings/v8/V8Utilities.cpp - Issue 32323012: IDL compiler: move EventHandler null check out of generated bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Utilities.cpp

Issue 32323012: IDL compiler: move EventHandler null check out of generated bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8Utilities.cpp

diff --git a/Source/bindings/v8/V8Utilities.cpp b/Source/bindings/v8/V8Utilities.cpp

index 7d4e64becdf738f6e2ed32f9598ea4f023cbc46a..71d7493b164bbc2aeb7128e7b8b2535ecaa7da6e 100644

--- a/Source/bindings/v8/V8Utilities.cpp

+++ b/Source/bindings/v8/V8Utilities.cpp

@@ -149,6 +149,9 @@ void transferHiddenDependency(v8::Handle<v8::Object> object, EventListener* oldV

removeHiddenDependency(object, oldListenerObject, cacheIndex, isolate);

}

+ // Non-callable input should be treated as null

+ if (!newValue->IsNull() && !newValue->IsFunction())

+ newValue = v8::Null(isolate);

if (!newValue->IsNull() && !newValue->IsUndefined())

createHiddenDependency(object, newValue, cacheIndex, isolate);

}