Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: Source/bindings/v8/V8EventListenerList.cpp

Issue 32323012: IDL compiler: move EventHandler null check out of generated bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8EventListenerList.cpp
diff --git a/Source/bindings/v8/V8EventListenerList.cpp b/Source/bindings/v8/V8EventListenerList.cpp
index 24eccb804975126d4f639f0d214871cad75e5651..c37eeb5a0c6aa8cae8ad355494ae3b0fb02f2fd8 100644
--- a/Source/bindings/v8/V8EventListenerList.cpp
+++ b/Source/bindings/v8/V8EventListenerList.cpp
@@ -42,11 +42,12 @@ PassRefPtr<EventListener> V8EventListenerList::getEventListener(v8::Local<v8::Va
v8::Handle<v8::Context> context = v8::Context::GetCurrent();
if (context.IsEmpty())
return 0;
+ v8::Isolate* isolate = context->GetIsolate();
if (lookup == ListenerFindOnly)
- return V8EventListenerList::findWrapper(value, isAttribute, context->GetIsolate());
+ return V8EventListenerList::findWrapper(value, isAttribute, isolate);
if (V8DOMWrapper::isWrapperOfType(toInnerGlobalObject(context), &V8Window::info))
- return V8EventListenerList::findOrCreateWrapper<V8EventListener>(value, isAttribute, context->GetIsolate());
- return V8EventListenerList::findOrCreateWrapper<V8WorkerGlobalScopeEventListener>(value, isAttribute, context->GetIsolate());
+ return V8EventListenerList::findOrCreateWrapper<V8EventListener>(value, isAttribute, isolate);
Nils Barth (inactive) 2013/10/22 07:29:29 This call fails if we don't add the isAttribute ch
+ return V8EventListenerList::findOrCreateWrapper<V8WorkerGlobalScopeEventListener>(value, isAttribute, isolate);
}
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698