Win Clang FYI bots: build chromium_builder_tests and run the standard set of tests

Win Clang FYI bots: build chromium_builder_tests and run the standard set of tests

We tried this before, in r265944, but failed to link some targets in
chromium_builder_tests because of lacking support for dll attributes.
Now it should work.

BUG=82385
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=276416

[hans, 2014-06-10 22:48:07]

I tested building 'chromium_builder_tests' locally in Release and Debug mode.

I noticed that tests_win_1 + tests_win_2 doesn't include content_unittests,
which we currently run. Maybe that should be added to the list?

[Reid Kleckner, 2014-06-10 23:14:49]

lgtm

https://codereview.chromium.org/323223002/diff/1/masters/master.chromium.fyi/...
File masters/master.chromium.fyi/master.cfg (left):

https://codereview.chromium.org/323223002/diff/1/masters/master.chromium.fyi/...
masters/master.chromium.fyi/master.cfg:860: win_clang_tests = [
Given that content_unittests is missing, maybe we should do
win_clang_tests = tests_win_1 + tests_win_2 + ['content_unittests']

[hans, 2014-06-10 23:34:10]

On 2014/06/10 23:14:49, Reid Kleckner wrote:
> lgtm
> 
>
https://codereview.chromium.org/323223002/diff/1/masters/master.chromium.fyi/...
> File masters/master.chromium.fyi/master.cfg (left):
> 
>
https://codereview.chromium.org/323223002/diff/1/masters/master.chromium.fyi/...
> masters/master.chromium.fyi/master.cfg:860: win_clang_tests = [
> Given that content_unittests is missing, maybe we should do
> win_clang_tests = tests_win_1 + tests_win_2 + ['content_unittests']

sgtm

New patch uploaded.

[Timur Iskhodzhanov, 2014-06-11 07:43:44]

https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium....
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium....
masters/master.chromium.fyi/master.cfg:885: tests=without(win_clang_tests,
['sandbox']),
This won't work as you'd expect?
Probably you wanted
  without(..., ['sbox_integration_tests'])

[Timur Iskhodzhanov, 2014-06-11 07:44:57]

https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium....
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium....
masters/master.chromium.fyi/master.cfg:885: tests=without(win_clang_tests,
['sandbox']),
Please add
# ASan doesn't support sandboxing on Windows yet (http://crbug.com/382867).

[hans, 2014-06-11 15:50:23]

New patch uploaded.

https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium....
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium....
masters/master.chromium.fyi/master.cfg:885: tests=without(win_clang_tests,
['sandbox']),
On 2014/06/11 07:43:44, Timur Iskhodzhanov wrote:
> This won't work as you'd expect?
> Probably you wanted
>   without(..., ['sbox_integration_tests'])

tests_win_1 doesn't include 'sbox_integration_tests', it just includes
'sandbox', which will then get magically expanded to actual tests depending on
the platform (see chromium_factory.pt:446).

I think excluding 'sandbox' here should work.

https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium....
masters/master.chromium.fyi/master.cfg:885: tests=without(win_clang_tests,
['sandbox']),
On 2014/06/11 07:44:57, Timur Iskhodzhanov wrote:
> Please add
> # ASan doesn't support sandboxing on Windows yet (http://crbug.com/382867).

Done.

[Timur Iskhodzhanov, 2014-06-11 15:58:45]

lgtm

https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium....
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium....
masters/master.chromium.fyi/master.cfg:885: tests=without(win_clang_tests,
['sandbox']),
On 2014/06/11 15:50:23, hans wrote:
> On 2014/06/11 07:43:44, Timur Iskhodzhanov wrote:
> > This won't work as you'd expect?
> > Probably you wanted
> >   without(..., ['sbox_integration_tests'])
> 
> tests_win_1 doesn't include 'sbox_integration_tests', it just includes
> 'sandbox', which will then get magically expanded to actual tests depending on
> the platform (see chromium_factory.py:446).

Oh, didn't know that.

> I think excluding 'sandbox' here should work.

OK, looks like you're right.

[hans, 2014-06-11 16:01:01]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2014-06-11 16:02:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hans@chromium.org/323223002/40001

[commit-bot: I haz the power, 2014-06-11 16:02:38]

Change committed as 276416