Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 323223002: Win Clang FYI bots: build chromium_builder_tests and run the standard set of tests (Closed)

Created:
6 years, 6 months ago by hans
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Win Clang FYI bots: build chromium_builder_tests and run the standard set of tests We tried this before, in r265944, but failed to link some targets in chromium_builder_tests because of lacking support for dll attributes. Now it should work. BUG=82385 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=276416

Patch Set 1 #

Total comments: 1

Patch Set 2 : Also run content_unittests #

Total comments: 5

Patch Set 3 : Rebase, add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -23 lines) Patch
M masters/master.chromium.fyi/master.cfg View 1 2 3 chunks +6 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hans
I tested building 'chromium_builder_tests' locally in Release and Debug mode. I noticed that tests_win_1 + ...
6 years, 6 months ago (2014-06-10 22:48:07 UTC) #1
Reid Kleckner
lgtm https://codereview.chromium.org/323223002/diff/1/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (left): https://codereview.chromium.org/323223002/diff/1/masters/master.chromium.fyi/master.cfg#oldcode860 masters/master.chromium.fyi/master.cfg:860: win_clang_tests = [ Given that content_unittests is missing, ...
6 years, 6 months ago (2014-06-10 23:14:49 UTC) #2
hans
On 2014/06/10 23:14:49, Reid Kleckner wrote: > lgtm > > https://codereview.chromium.org/323223002/diff/1/masters/master.chromium.fyi/master.cfg > File masters/master.chromium.fyi/master.cfg (left): ...
6 years, 6 months ago (2014-06-10 23:34:10 UTC) #3
Timur Iskhodzhanov
https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium.fyi/master.cfg#newcode885 masters/master.chromium.fyi/master.cfg:885: tests=without(win_clang_tests, ['sandbox']), This won't work as you'd expect? Probably ...
6 years, 6 months ago (2014-06-11 07:43:44 UTC) #4
Timur Iskhodzhanov
https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium.fyi/master.cfg#newcode885 masters/master.chromium.fyi/master.cfg:885: tests=without(win_clang_tests, ['sandbox']), Please add # ASan doesn't support sandboxing ...
6 years, 6 months ago (2014-06-11 07:44:57 UTC) #5
hans
New patch uploaded. https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium.fyi/master.cfg#newcode885 masters/master.chromium.fyi/master.cfg:885: tests=without(win_clang_tests, ['sandbox']), On 2014/06/11 07:43:44, Timur ...
6 years, 6 months ago (2014-06-11 15:50:23 UTC) #6
Timur Iskhodzhanov
lgtm https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/323223002/diff/20001/masters/master.chromium.fyi/master.cfg#newcode885 masters/master.chromium.fyi/master.cfg:885: tests=without(win_clang_tests, ['sandbox']), On 2014/06/11 15:50:23, hans wrote: > ...
6 years, 6 months ago (2014-06-11 15:58:45 UTC) #7
hans
The CQ bit was checked by hans@chromium.org
6 years, 6 months ago (2014-06-11 16:01:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/323223002/40001
6 years, 6 months ago (2014-06-11 16:02:02 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 16:02:38 UTC) #10
Message was sent while issue was closed.
Change committed as 276416

Powered by Google App Engine
This is Rietveld 408576698