Win Clang FYI bots: build chromium_builder_tests and run the standard set of tests

masters/master.chromium.fyi/master.cfg

 # vim: ft=python:
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from buildbot.changes import svnpoller
 from buildbot.scheduler import Dependent
 from buildbot.scheduler import Nightly
 from buildbot.scheduler import Periodic
 from buildbot.scheduler import Scheduler
@@ skipping 839 matching lines @@
     slave_type='BuilderTester',
     clobber=True,
     target='Release_x64',
     tests=win_x64_tests,
     options=['--build-tool=ninja', '--', 'chromium_builder_tests'],
     factory_properties={
       'gclient_env': {
         'GYP_DEFINES': 'target_arch=x64',
     }})
 
-win_clang_tests = [
-    'base_unittests',
-    'browser_tests',
-    'cc_unittests',
-    'components_unittests',
-    'content_unittests',
-    'crypto_unittests',
-    'ipc_tests',
-    'net_unittests',
-    'printing_unittests',
-    'remoting_unittests',
-    'sbox_integration_tests',
-    'sbox_unittests',
-    'sbox_validation_tests',
-    'sql_unittests',
-    'unit_tests',
-    'url_unittests',
-]
+win_clang_tests = tests_win_1 + tests_win_2 + ['content_unittests']
 
 f_chromium_win_clang = win_out().ChromiumFactory(
     slave_type='BuilderTester',
     target='Release',
     tests=win_clang_tests,
-    # TODO(hans): Build chromium_builder_tests when LLVM PR11170 is fixed.
-    options=['--build-tool=ninja', '--'] + win_clang_tests,
+    options=['--build-tool=ninja', '--', 'chromium_builder_tests'],
     factory_properties={
       'gclient_env': {
         'GYP_DEFINES': 'clang=1',
     }})
 
 f_chromium_win_clang_dbg = win_out().ChromiumFactory(
     slave_type='BuilderTester',
     target='Debug',
     tests=win_clang_tests,
-    options=['--build-tool=ninja', '--'] + win_clang_tests,
+    options=['--build-tool=ninja', '--', 'chromium_builder_tests'],
     factory_properties={
       'gclient_env': {
         'GYP_DEFINES': 'clang=1 component=static_library',
     }})
 
 f_chromium_win_clang_asan = win_out().ChromiumFactory(
     slave_type='BuilderTester',
     target='Release',
-    tests=win_clang_tests,
-    options=['--build-tool=ninja', '--'] + win_clang_tests,
+    tests=without(win_clang_tests, ['sandbox']),

[Timur Iskhodzhanov, 2014/06/11 07:43:44]

This won't work as you'd expect?
Probably you wanted
  without(..., ['sbox_integration_tests'])

[Timur Iskhodzhanov, 2014/06/11 07:44:57]

Please add
# ASan doesn't support sandboxing on Windows yet (http://crbug.com/382867).

[hans, 2014/06/11 15:50:23]

tests_win_1 doesn't include 'sbox_integration_tests', it just includes
'sandbox', which will then get magically expanded to actual tests depending on
the platform (see chromium_factory.pt:446).

I think excluding 'sandbox' here should work.

[hans, 2014/06/11 15:50:23]

Done.

[Timur Iskhodzhanov, 2014/06/11 15:58:45]

Oh, didn't know that.
OK, looks like you're right.

+    options=['--build-tool=ninja', '--', 'chromium_builder_tests'],
     factory_properties={
       'asan': True,
       'gclient_env': {
         'GYP_DEFINES': 'clang=1 asan=1 component=static_library disable_nacl=1',
     }})
 
 f_chromium_win_ninja_shared_2013_dbg = win_out().ChromiumFactory(
     slave_type='BuilderTester',
     options=['--build-tool=ninja', 'chromium_builder_tests'],
     tests=tests_win_1,
@@ skipping 1393 matching lines @@
 
 c['status'].append(MailNotifier(
       fromaddr='ukai@chromium.org',  # Reply-To address
       mode='failing',
       categories=['goma'],
       relayhost=config.Master.smtp,
       subject='goma canary buildbot %(result)s in %(projectName)s '
               'on %(builder)s',
       extraRecipients=['goma+alert@google.com'],
       sendToInterestedUsers=False))